Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-1643 Pre-commit CI #205

Merged
merged 1 commit into from
May 21, 2024
Merged

PM-1643 Pre-commit CI #205

merged 1 commit into from
May 21, 2024

Conversation

Smorci
Copy link
Contributor

@Smorci Smorci commented May 21, 2024

CI running pre-commit hooks to check on PRs and merges that the hooks were installed by the contributors

@Smorci Smorci self-assigned this May 21, 2024
@Smorci Smorci force-pushed the PM-1643-pre-commit-ci branch from a84f7de to 434f540 Compare May 21, 2024 21:38
@Smorci Smorci marked this pull request as ready for review May 21, 2024 21:40
Copy link
Collaborator

@johnmarcou johnmarcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Short and simple, I love that 👍 Nice work!

@Smorci Smorci merged commit 5d97676 into main May 21, 2024
1 check passed
@Smorci Smorci deleted the PM-1643-pre-commit-ci branch May 21, 2024 22:08
Copy link
Collaborator

@simisimis simisimis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: When adding new workflows I would suggest use latest actions versions, i e. actions/checkout v4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants