Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PM-1973 - Revise Leaderboard web #13

Merged
merged 7 commits into from
Sep 13, 2024
Merged

PM-1973 - Revise Leaderboard web #13

merged 7 commits into from
Sep 13, 2024

Conversation

piotr-iohk
Copy link
Contributor

This PR:

  • removes some redundant html and php code
  • sanitizes and validates parameters that are used as POST arguments in ajax requests
  • makes sure that POST data arrays only use allowed keys

@piotr-iohk piotr-iohk self-assigned this Sep 12, 2024
simisimis
simisimis approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@simisimis simisimis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piotr-iohk piotr-iohk force-pushed the investigate-leaderboard-web branch from 4f7a369 to 3e74faf Compare September 13, 2024 09:28
@piotr-iohk piotr-iohk merged commit 3409974 into main Sep 13, 2024
@piotr-iohk piotr-iohk deleted the investigate-leaderboard-web branch September 13, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simisimis simisimis simisimis approved these changes

@alitejawi-mf alitejawi-mf Awaiting requested review from alitejawi-mf

Assignees

@piotr-iohk piotr-iohk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piotr-iohk @simisimis