Add storage and system card service for writing results away #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Anne Schuth <[email protected]> Signed-off-by: Robbert Uittenbroek <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to our community 🤗 and thank you for your first contribution.
As a first time contributor please make sure to review our contribution guidelines ❤️
laurensWe
force-pushed
the
write-done-task-to-system-card
branch
from
c783c15
to
0f68ea7
Compare
anneschuth
reviewed
May 28, 2024
laurensWe
force-pushed
the
write-done-task-to-system-card
branch
from
3842756
to
9200036
Compare
laurensWe
force-pushed
the
write-done-task-to-system-card
branch
from
9200036
to
6706ba9
Compare
anneschuth
reviewed
May 28, 2024
tests/services/test_storage.py
Outdated
| from yaml import safe_load | ||
|
|
||
|
|
||
| @pytest.mark.skip(reason="This is an initialisation function for the tests") |
There was a problem hiding this comment.
I believe fixtures are meant for this kind of functionalty, or is there a reason to do it like this?
There was a problem hiding this comment.
Changed this to use fixtures
anneschuth
approved these changes
May 28, 2024
uittenbroekrobbert
force-pushed
the
setup-mvp-cards
branch
2 times, most recently
from
fccce5c
to
d8f7b92
Compare
|
I first rebased this branch (locally) onto the setup-mvp-cards branch, as that is ready to merge into main. Due to those changes, I believe some tests don't work anymore. I'll look into this. |
uittenbroekrobbert
force-pushed
the
setup-mvp-cards
branch
2 times, most recently
from
b211a4f
to
ac57364
Compare
|
Closed because it is duplicate of #30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Two services are added, one Storage service which handles writing away of .yaml files to different storage locations the second service is the basic implementation of a system card to be extended for full system card functionality.
Link all GitHub issues fixed by this PR.
Resolves #
Checklist
Please check all the boxes that apply to this pull request using "x":