Render system card #188
Merged
Render system card #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
amt/api/routes/project.py
Outdated
| ) | ||
|
|
||
| if not assessment_card_data: | ||
| logger.warning(f"assessment card with name {assessment_card} not found") |
Check notice
Code scanning / SonarCloud
Logging should not be vulnerable to injection attacks
amt/api/routes/project.py
Outdated
| model_card_data = get_include_contents(Path("example_system_card/"), "system_card.yaml", "models", model_card) | ||
|
|
||
| if not model_card_data: | ||
| logger.warning(f"model card with name {model_card} not found") |
Check notice
Code scanning / SonarCloud
Logging should not be vulnerable to injection attacks
amt/api/routes/project.py
Outdated
| logger.info(f"fetching {search_key} contents from {include_path}") | ||
| return file_system_storage_service.read() | ||
|
|
||
| logger.warning(f"could not fetching {search_key} contents") |
Check notice
Code scanning / SonarCloud
Logging should not be vulnerable to injection attacks
ChristopherSpelt
force-pushed
the
104-system-card-viewer-in-frontend
branch
from
a0af376
to
23fa3e6
Compare
ChristopherSpelt
force-pushed
the
104-system-card-viewer-in-frontend
branch
3 times, most recently
from
a571833
to
0a077eb
Compare
|
LGTM! |
|
Could we make
|
laurensWe
reviewed
Sep 12, 2024
ChristopherSpelt
force-pushed
the
104-system-card-viewer-in-frontend
branch
from
cbf014c
to
ea7763b
Compare
@anneschuth : processed your comments |
anneschuth
reviewed
Sep 12, 2024
ChristopherSpelt
force-pushed
the
104-system-card-viewer-in-frontend
branch
from
ea7763b
to
edbf834
Compare
ChristopherSpelt
force-pushed
the
104-system-card-viewer-in-frontend
branch
from
edbf834
to
5ab3ec4
Compare
ChristopherSpelt
force-pushed
the
104-system-card-viewer-in-frontend
branch
2 times, most recently
from
ce2fe7a
to
8a8df8b
Compare
ChristopherSpelt
force-pushed
the
104-system-card-viewer-in-frontend
branch
2 times, most recently
from
9cae1c3
to
7cac945
Compare
ChristopherSpelt
force-pushed
the
104-system-card-viewer-in-frontend
branch
from
7cac945
to
c251252
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements rendering of
There is also a rendering of a model card, but because there was no example and this does not have priority the styling is far from optimal.
Implementation notes
There seem to be missing style elements. These are not implemented.
hide details/show morebuttonThe ticket specified URL's as
Projects/{project_id}/system_card/{assesment_card_name}/andProjects/{project_id}/system_card/{model_card_name}/. I have changed this toProjects/{project_id}/system_card/assessments/{assesment_card_name}/andProjects/{project_id}/system_card/models/{model_card_name}/resp.The system card path is now hardcoded in the endpoint. This needs to be changed when the system card flow in the AMT app is working, also the tests need to be refactored.
How to see the rendering?
Make sure at least 1 project exists. Pick one project with id
project_id. Go to:Projects/{project_id}/system_cardResolves #104
Checklist
Please check all the boxes that apply to this pull request using "x":