Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add frontend building versioning and testing #145

Merged
merged 3 commits into from
Aug 27, 2024
Merged

add frontend building versioning and testing #145

merged 3 commits into from
Aug 27, 2024

Conversation

berrydenhartog
Copy link
Member

@berrydenhartog berrydenhartog commented Aug 21, 2024 •
edited
Loading

Description

Add frontend building system.

Resolves #55

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@berrydenhartog berrydenhartog linked an issue Aug 21, 2024 that may be closed by this pull request
Add frontend building, versioning and testing #55
Closed
@berrydenhartog berrydenhartog force-pushed the 55-add-frontend-building-versioning-and-testing branch from 52bc13f to 2532bd5 Compare August 21, 2024 10:45
@laurensWe laurensWe mentioned this pull request Aug 21, 2024
Merged
5 tasks
@berrydenhartog berrydenhartog force-pushed the 55-add-frontend-building-versioning-and-testing branch 2 times, most recently from 29ef7e9 to 981651b Compare August 21, 2024 17:47
laurensWe
laurensWe reviewed Aug 22, 2024
View reviewed changes
USAGE.md Show resolved Hide resolved
@berrydenhartog berrydenhartog marked this pull request as ready for review August 22, 2024 12:29
@berrydenhartog berrydenhartog requested a review from a team as a code owner August 22, 2024 12:29
@berrydenhartog
Copy link
Member Author

As discussed with @anneschuth for now we leave out tests since i could not get it to work

@berrydenhartog berrydenhartog force-pushed the 55-add-frontend-building-versioning-and-testing branch from 98912bd to 48ce92f Compare August 22, 2024 12:30
laurensWe
laurensWe reviewed Aug 22, 2024
View reviewed changes
BUILD.md Outdated Show resolved Hide resolved
laurensWe
laurensWe reviewed Aug 22, 2024
View reviewed changes
Dockerfile Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
amt/api/deps.py Show resolved Hide resolved
@anneschuth
Copy link
Member

Do we still want to use scss?

@berrydenhartog
Copy link
Member Author

berrydenhartog commented Aug 22, 2024 •
edited
Loading

Do we still want to use scss?

Added scss support @anneschuth

@berrydenhartog berrydenhartog force-pushed the 55-add-frontend-building-versioning-and-testing branch 3 times, most recently from 0e53bd1 to 1857cfe Compare August 22, 2024 14:35
@uittenbroekrobbert
Copy link
Contributor

Perhaps the package.json needs te be added (excluded) in the .github/CODEOWNERS file so dependabot can update it automatically.

@berrydenhartog berrydenhartog force-pushed the 55-add-frontend-building-versioning-and-testing branch from 87fa598 to 2abbd09 Compare August 26, 2024 06:41
@berrydenhartog
Copy link
Member Author

Perhaps the package.json needs te be added (excluded) in the .github/CODEOWNERS file so dependabot can update it automatically.

Done

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
6.9% Coverage on New Code (required ≥ 95%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

laurensWe
laurensWe approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@laurensWe laurensWe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes :)

@berrydenhartog berrydenhartog merged commit fcb076c into main Aug 27, 2024
15 of 16 checks passed
@berrydenhartog berrydenhartog deleted the 55-add-frontend-building-versioning-and-testing branch August 27, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uittenbroekrobbert uittenbroekrobbert uittenbroekrobbert left review comments

@laurensWe laurensWe laurensWe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add frontend building, versioning and testing
4 participants
@berrydenhartog @anneschuth @uittenbroekrobbert @laurensWe