Add automatic naming conventions for database relations #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uittenbroekrobbert
force-pushed
the
125-sqlachemy-naming-conventions
branch
from
90a951d
to
8750524
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change enforces using default naming conventions when creating relationships with alembic.
By default, sqlalchemy does not enforce any naming rules on relations in the database, like foreign keys. This means when not specified, database defaults are used. This can cause problems when DDL/DML changes are done through alembic, and we don't know what name a relationship has.
To keep uniform names, older named relationships are also renamed in migration scripts. This means databases have to be fully recreated.
Resolves #125
Checklist
Please check all the boxes that apply to this pull request using "x":