Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run when PR is merged #117

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Run when PR is merged #117

merged 1 commit into from
Jul 31, 2024

Conversation

laurensWe
Copy link
Member

@laurensWe laurensWe commented Jul 31, 2024

Description

The Github Action to clean up the container registry doesn't run when a PR is merged into main, this extra trigger would potentially help and solve this.

In the docs: https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request

'''The pull_request webhook event payload is empty for merged pull requests and pull requests that come from forked repositories.'''

Inspiration taken from: https://github.com/orgs/community/discussions/26724

Link all GitHub issues fixed by this PR.
Make sure to first open an issue, get community approval and only then create Pull Request to resolve it.
All Pull Requests must have an issue attached to them

Resolves #

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

Copy link

sonarcloud bot commented Jul 31, 2024

@laurensWe laurensWe merged commit d005786 into main Jul 31, 2024
14 checks passed
@laurensWe laurensWe deleted the bugfix/ghcr branch July 31, 2024 08:36
@laurensWe laurensWe linked an issue Jul 31, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bugfix de github cleaner github action
2 participants