Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Parameter Name in wpMandrill Plugin - 'meta_data' should be 'metadata' #93

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

timi-ro
Copy link

@timi-ro timi-ro commented Nov 1, 2023

Description:
I have noticed a minor issue in the wpMandrill plugin, which I believe is a bug. In the plugin, while sending emails and setting metadata, the parameter definition for metadata is named 'meta_data' instead of the correct 'metadata'. This inconsistency causes problems when trying to retrieve the metadata through the Mandrill API.

Steps to Reproduce:
Use the wpMandrill plugin to send an email.
Include metadata by passing an array to the 'meta_data' parameter in the 'wpMandrill::mail()' function.
Attempt to retrieve this metadata using the Mandrill API for the sent email.
Expected Behavior:
The plugin should use 'metadata' as the parameter name for setting metadata, which aligns with Mandrill's naming convention.

Actual Behavior:
The plugin uses 'meta_data' as the parameter name, which results in difficulties when trying to access the metadata through the Mandrill API. The API expects 'metadata' as the parameter name.

Additional Information:
This inconsistency may cause confusion and issues for users who want to work with the Mandrill API to retrieve email metadata.
It is a small but significant bug as it affects the plugin's functionality and compatibility with Mandrill.
To correct this, it is recommended to update the 'meta_data' parameter to 'metadata' in the plugin's codebase.
Please consider making this change in the wpMandrill plugin to ensure better compatibility with Mandrill and enhance user experience. Thank you for your attention to this matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants