Install fix, albumentations pydantic insightface, onnxruntime-gpu #2761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w-e-w
changed the title
dependency incompatibility compatibility with albumentations==1.4.4 whitch requires - pydantic required: >=2.6.4 webui 1.9 with gradio==3.41.2 / fastapi==0.94.0 requires - pydantic required: >=1.7.4,<3.0.0,!=2.0.1,!=2.0.0,!=1.8.1,!=1.8 solution for now pin albumentations==1.4.3 as control net requirement which doesn't requires pydantic
w-e-w
changed the title
huchenlei
approved these changes
Apr 18, 2024
|
you're welcome |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First critical installation issue
insightfacespecifiesanyversion ofalbumentationsand so will pip will install the newest version of
albumentationsalbumentationshad an update1.4.4in the past 24 hr see pypi/albumentations/historyit introduces a new requirement
webui 1.9 with gradio==3.41.2 / fastapi==0.94.0 requires
webui 1.9 is not compatible with
pydantic>=2.0which causes web UI to not launch
solution for now
in controlnet
pin
albumentations==1.4.3as control net requirementif
albumentations==1.4.3is installed beforeinsightfacepip won't auto install the newest version1.4.4I did a quick tested with
ip-adapter, all variant seems to work fine after this PR, but today is the first time I useip-adapterso I'm not sure if it's actually working properlyTo get webui back working
outdated
First
after install of
insightfacepydanticwill update from1.10.15->2.7.0and as far as I'm aware it is not compatible with
fastapi==0.94.0/gradio==3.41.2and woud cause webui to crash
so to "fix" this I've added some code that would revert the
pydanticversion to what it was afterinsightfaceis installedI'm not sure because I have not played with ip-adapter before
but this downgrading
pydanticto1.10.15seems to casueip-adapter_face_id/plusto breakSecond issue not as critical
they exist
onnxruntimeandonnxruntime-gpuas far as I know they are interchangeable but they cannot coexist in the same environment (unless things has changed since)
in lots of use cases it doesn't really matter if you're running on CPU but for other extensions they might requires the extra performance
so I believe currently it's best to install the GPU version even if you don't need it as long as GPU is available
these are several instances of extensions checking for GPU before installing the appropriate onnxruntime
https://github.com/Gourieff/sd-webui-reactor/blob/main/install.py#L104-L124
Gourieff/sd-webui-reactor#170 (comment)
https://github.com/w-e-w/sd-webui-nudenet-nsfw-censor/blob/main/install.py
https://github.com/aria1th/sd-webui-nsfw-filter/blob/main/install.py
https://github.com/diffus-me/sd-webui-facefusion/blob/main/install.py#L22-L28
other changes
https://docs.python.org/3/whatsnew/3.12.html
and it seems to work better as in it's able to observe version changes before and after installation of packages
in previous commit I observedly change in the versions of packages and and reverting it
not important but since I already change I didn't bother reverting it