Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Semantic text query #1

Conversation

Mikep86
Copy link
Owner

@Mikep86 Mikep86 commented Feb 22, 2024

Draft PR to track the progress of the semantic_query implementation. Built on top of Carlos's dense vector support PR: elastic#105515

Apologies for the non-standard PR location, this was the only way I could find to create a PR that used carlosdelest/semantic-text-dense-vector-support as the base branch.

This PR will never be merged. It is intended to be used for only discussion & collaboration on the semantic_query implementation. Once the dense vector support PR is merged, I will open a new PR that uses elastic:feature/semantic-text as a base branch.

DaveCTurner and others added 27 commits March 4, 2024 14:37
We changed field extraction in ES|QL in 8.12 quite a bit so our tests
would have to be super complex to test a cluster of mixed versions
between 8.11 and `main`. So let's just skip it.

Closes elastic#105837
The health report API changed names in
elastic#92879, which causes this
YAML REST test to fail in versions < 8.7.0.

Closes elastic#105923
… codebase (elastic#105882)

Found a bunch more spots where this shortcut helps save both memory and
brainpower for thinking through potential leaks.
=> made use of it and sometimes also inlined a couple local variables
for readability.
This change updates allocation explanation message for the DataTierDecider to include the actual role (eg generic data or specific data_*) that permitted the shard to be allocated to the node.
* Simplify version node_selector: remove ranges and allow just current/non_current
* Version match still present, but only for legacy rest compat tests
The GeoIP endpoint does not use the xpack http client. The GeoIP downloader uses the JDKs builtin cacerts.

If customer is using custom https endpoint they need to provide the cacert in the jdk, whether our jdk bundled in or their jdk. Otherwise they will see something like
```
...PKiX path building failed: sun.security.provier.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target...
```
# Conflicts:
#	server/src/main/java/org/elasticsearch/TransportVersions.java
On Serverless it is not possible to configure deprecation indexing (it
is always off). This commit updates the behaviour of
`ElasticsearchCluster` to no longer attempt to configure deprecation
indexing on stateless nodes.
increase ILM logging to TRACE.

Relates to elastic#103981
…ests (elastic#105731)



This setting requires expensive processing due to verification the integrity of many important files during a shard recovery or relocation.

Therefore, it takes lots of time for the files to clean up and the assertShardFolder check may not complete in 30s.

Fixes elastic#105202
Addresses test bug introduced in elastic#105721: we must consume all the
`SnapshotInfo` instances before completing the final listener.

Closes elastic#105922
…5930)

This change ensures that the matches implementation of the `SourceConfirmedTextQuery` only checks the current document instead of calling advance on the two phase iterator. The latter tries to find the first doc that matches the query instead of restricting the search to the current doc. This can lead to abnormally slow highlighting if the query is very restrictive and the highlight is done on a non-matching document.

Closes elastic#103298
…c#105912)

* Bugfix for CCR queries using text expansion

* Fix test

* PR feedback

* Fix test

* Minor cleanup

* Edit comment

* One more comment clarification

---------

Co-authored-by: Elastic Machine <[email protected]>
… API (elastic#105797)

* Retrying on 500

* Update docs/changelog/105797.yaml

---------

Co-authored-by: Elastic Machine <[email protected]>
@Mikep86
Copy link
Owner Author

Mikep86 commented Mar 11, 2024

Closed & replaced with elastic#106181

@Mikep86 Mikep86 closed this Mar 11, 2024
Mikep86 pushed a commit that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.