Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GD-421: Add uid:// path support to Scene Runner #422

Merged
merged 4 commits into from
Apr 29, 2024
Merged

GD-421: Add uid:// path support to Scene Runner #422

merged 4 commits into from
Apr 29, 2024

Conversation

mpewsey
Copy link
Contributor

@mpewsey mpewsey commented Apr 29, 2024

Why

This PR adds uid:// path support to the Scene Runner per #421.

What

  • Changed the file path exists check from using FileAccess.file_exists to ResourceLoader.exists since the Resource Loader method works for uid:// paths.
  • Added a check for the binary scene extension .scn.
  • Added a new test for the uid:// path. The test was copied from test_runner_by_resource_path() but uses the uid:// path for the test scene instead.

Closes #421

@MikeSchulze MikeSchulze changed the title Add Uid path support to Scene Runner GD-421: Add uid:// path support to Scene Runner Apr 29, 2024
@MikeSchulze
Copy link
Owner

Thanks for contributing to this project.
The PR looks good, please check my comments.

@MikeSchulze MikeSchulze merged commit 4a0855c into MikeSchulze:master Apr 29, 2024
@MikeSchulze MikeSchulze added the enhancement New feature or request label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeSchulze MikeSchulze MikeSchulze left review comments

Assignees

@mpewsey mpewsey

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GD-421: Add uid path support to Scene Runner
2 participants
@mpewsey @MikeSchulze