Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default logfile enabling issue #62

Closed
MikeHeiber opened this issue Jan 18, 2019 · 2 comments
Closed

Fix default logfile enabling issue #62

MikeHeiber opened this issue Jan 18, 2019 · 2 comments
Assignees
@MikeHeiber
Labels
bug Mistake in the code that causes a testable error.

Comments

@MikeHeiber
Copy link
Owner

The problem is that the default value for enabling logging is not defined in the Parameters_Simulation class header file, so the behavior of running the simulation without setting this parameter is undefined. Even if a derived simulation class does not enable logging, the compiler may interpret it as being enabled, which can cause errors.
@MikeHeiber MikeHeiber added the bug Mistake in the code that causes a testable error. label Jan 18, 2019
@MikeHeiber MikeHeiber self-assigned this Jan 18, 2019
MikeHeiber added a commit that referenced this issue Jan 18, 2019
@MikeHeiber
Default Parameters Bugfix
b5df5ed 
- Resolves #62
-Added default values for all parameters in Parameters_Simulation and Parameters_Lattice to avoid undefined behavior with uninitialized parameters
-Added tests that the default values for the Parameters_Simulation and Parameters_Lattice objects are invalid parameters
@MikeHeiber
Copy link
Owner Author

This bug is resolved now on the joss-edits branch and will be merged into master with the rest of the joss-edits corrections once the paper review process is completed.

@MikeHeiber MikeHeiber mentioned this issue Jan 18, 2019
Closed
36 tasks
@MikeHeiber MikeHeiber mentioned this issue Jan 23, 2019
Merged
MikeHeiber added a commit that referenced this issue Jan 23, 2019
@MikeHeiber
Joss edits (#63)
7172127 
Resolves #59 and #62 
-Updated CHANGELOG with notes about the most recent changes
-Made several previous changelog notes more concise
-Corrected errors in the paper bibtex entry formatting and added some missing reference info 
-Fixed incorrect copyright statement years in test.cpp and test_mpi.cpp
-Added line to .gitignore file to ignore the x64 build directory
-Added default values for all parameters in Parameters_Simulation and Parameters_Lattice to avoid undefined behavior with uninitialized parameters
-Added tests that the default values for the Parameters_Simulation and Parameters_Lattice objects are invalid parameters
-Fixed several typos and spelling mistakes in the documentation source files
-Updated the Doxygen documentation files
-Updated changelog heading for the changes coming in v2.0.0
-Updated README by changing current status to note the release of a stable v2.0
-Updated README by modifying the acknowledgements for v2.0
@MikeHeiber
Copy link
Owner Author

Resolved this issue in PR #63 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MikeHeiber MikeHeiber

Labels
bug Mistake in the code that causes a testable error.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MikeHeiber