-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make IPv4-mapped support optional and embedded support obligatory #362
Conversation
👍 for the corrected and added test vector. Not sure about the added text in the "ipv4hint" and "ipv6hint" section. I don't think you should just say "For security reasons" without saying what those reasons are. I suppose it would also be fine to just leave that text out. What do you think @DesWurstes ? Did you have a specific attack vector in mind? |
Agreed on "security reasons". But also, spelled out in the text or not, what is the motivation for requiring clients reject those values? I didn't think we did such things in, e.g., AAAA records. (@ericorth to confirm.) |
Yeah, I don't think we should be trying to identify which addresses are and are not eligible to be included in a hint. As much as possible, I think they should be just like |
Updated. Now only embedded-v4 support is obligatory as @wtoorop suggests (to increase compat with dnsop). Or would you prefer to make it "SHOULD" as well? In that case I should remove the test case and add a note under "ipv6hint" |
Co-authored-by: Benjamin M. Schwartz <[email protected]>
Do we want an operational consideration recommending against using them? Having IPv4-mapped addresses in AAAA records is a common operational mistake. |
Then how about "Nameservers SHOULD NOT use IPv4-mapped addresses in ipv6hint as the functioning of such addresses is highly implementation-dependent." ? I hope someone can come up with a better suggestion. |
Is there something about SVCB that changes the considerations here? No strong objections, but it seems to me we can assume this covered by existing stuff. |
Really there is nothing new here. Nameservers already have to deal with mapped addresses in AAAA records. If your acl / connection logic doesn't handle mapped address already it is broken. |
I'll mail v6ops for guidance. |
I don't think this is specific to v4-mapped v6, or even v6 generally. IPv4 and IPv6 both have various special ranges that probably should not appear in the DNS, but the DNS is nonetheless capable of conveying them. I suspect that v4-mapped v6 is just one of many weird IP ranges that are commonly published due to an operational mistake. |
Then I would suggest the following under ipv6hint:
and maybe?
Although these will be treated exactly the same way in practice AAAA is treated it's good practice to remind programmers. |
I think this change is good as-is. In very long documents such as this, adding more guidance that should be obvious can make it harder to find the guidance that is not so obvious. |
Resolves #361
Looking forward for your comments @wtoorop