Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty spotify cover and album title #884

Merged
merged 1 commit into from
Apr 6, 2020
Merged

Fix empty spotify cover and album title #884

merged 1 commit into from
Apr 6, 2020

Conversation

lovethisshit
Copy link
Contributor

@lovethisshit lovethisshit commented Apr 3, 2020 •
edited
Loading

@lovethisshit lovethisshit changed the title Fix empty spotify cover and album title #799 #799 Fix empty spotify cover and album title Apr 3, 2020
@lovethisshit lovethisshit changed the title #799 Fix empty spotify cover and album title Fix empty spotify cover and album title Apr 3, 2020
s-martin
s-martin reviewed Apr 3, 2020
View reviewed changes
Copy link
Collaborator

@s-martin s-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@s-martin s-martin merged commit 4f72dc8 into MiczFlor:develop Apr 6, 2020
@s-martin s-martin added this to the 2.0 milestone Apr 6, 2020
@Hamsert
Copy link

Hamsert commented Apr 9, 2020

I did these changes to the corresponding file on my Phoniebox, but it seems like it didn't fix the problems.

@s-martin
Copy link
Collaborator

s-martin commented Apr 10, 2020 •
edited
Loading

I assume you did restart the webserver or reboot the Pi?

@lovethisshit or @fhaertig can you help?

@Hamsert
Copy link

Hamsert commented Apr 10, 2020

Yes I restarted the Pi after making the changes.

@lovethisshit
Copy link
Contributor Author

lovethisshit commented Apr 11, 2020 •
edited
Loading

Not sure, which version are you using?
I tried the solution mentioned here: https://stackoverflow.com/a/43750037 but it did work already without setting an explicit user agent. Maybe there is a system setting overriding this or saving the user agent?

Edit: I forgot to mention, obviously you should delete all title.txt and cover.jpg files, because the code won't run if already present (or test it with a completely new folder)

s-martin added a commit that referenced this pull request Apr 11, 2020
@s-martin @Groovylein
@MiczFlor @fredg02 @MalteHST @lovethisshit @fhaertig
fixed formatting warnings (#872)
b030ab9 
* save used git commit hash to version file (see #828)

* added first idea

* Get rid of debconf: falling back to frontend: Readline messages while installing

* Adapt for stretch dockerfile

* Added functions for logging

* Enable Logging during the installation

* Added config file information into logging

* Updated comments

* fixed flake8 warnings

* read current commit from Github

* Consolidate install scripts (#871)

* Remove duplicate chown/chmod

* Align stretch install scripts

* Remove stretch-install-spotify.sh script

* Add info about pkg installation (#879)

* Add info about pkg installation 

Fix for #818

* Update README.md

* added missing sudo

* Update Detect rfidoff function in gpio-buttons.py (#869)

* Update Detect rfidoff function in gpio-buttons.py

Adapted the RFID-Off function to the new gpio-buttons code structure. Works fine with the hardware hack for the USB-rfid reader described here:
#62

The rfidoff event is triggered when the used gpio is pulled down.

* Added Missing "Channel" to rfidoff Action

* add empty header context to spotify requests, fixes title and cover download (#884)

Co-authored-by: fhaertig <[email protected]>

* Add info how to post logging info (#882)

* fixed flake8 warnings

Co-authored-by: Kiri <[email protected]>
Co-authored-by: Groovylein <[email protected]>
Co-authored-by: Micz Flor <[email protected]>
Co-authored-by: Fred G <[email protected]>
Co-authored-by: MalteHST <[email protected]>
Co-authored-by: lovethisshit <[email protected]>
Co-authored-by: fhaertig <[email protected]>
@Hamsert
Copy link

Hamsert commented Apr 11, 2020

Edit: I forgot to mention, obviously you should delete all title.txt and cover.jpg files, because the code won't run if already present (or test it with a completely new folder)

This was the problem. After deleting the two files in my testfolder and rebooting the image and the title got loaded from spotify.

@Hamsert
Copy link

Hamsert commented Apr 12, 2020

One more thing: if I remember correctly it also used to show the cover of tracks I directly started from iris. Right now it just shows the last image of things I played earlier when I start something from iris. I probably have to delete another file as well, but which?
Thanks!

@lovethisshit
Copy link
Contributor Author

I think this is unrelated to this pull request, as the code i changed only writes the cover and title files. I might have time to look into this this week.

@Hamsert
Copy link

Hamsert commented Apr 13, 2020

Alright, thanks!

@MiczFlor MiczFlor mentioned this pull request May 23, 2020
Closed
@passuff
Copy link

passuff commented Sep 17, 2021

I have exactly the same issue even though th topic is closed. I just installed Version "2.3 - 2425890 - master". I think it's the most recent version. Cover.jpeg and title.txt are created but empty. Any help appreciated...

@passuff passuff mentioned this pull request Sep 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-martin s-martin s-martin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

🐛 | Spotify Name from Playlist not showing in Home View
5 participants
@lovethisshit @Hamsert @s-martin @passuff @fhaertig