Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: installation of py packages now for python 3 #843

Merged
merged 2 commits into from
Mar 8, 2020

Conversation

s-martin
Copy link
Collaborator

@s-martin s-martin commented Mar 8, 2020

Should fix #842 on master

Untested yet.

@s-martin s-martin added the bug label Mar 8, 2020
@s-martin s-martin requested a review from ZyanKLee March 8, 2020 08:52
@s-martin s-martin linked an issue Mar 8, 2020 that may be closed by this pull request
@s-martin
Copy link
Collaborator Author

s-martin commented Mar 8, 2020

In #842 it was confirmed that installation of py3 packages fixed the issue.

@s-martin s-martin changed the title Fix installation of py packages now for python 3 Hotfix: installation of py packages now for python 3 Mar 8, 2020
Copy link
Collaborator

@ZyanKLee ZyanKLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you leave lines 491 to 508 at python2.7 and mopidy2 on purpose?

@ZyanKLee ZyanKLee added this to the 2.0 milestone Mar 8, 2020
@s-martin
Copy link
Collaborator Author

s-martin commented Mar 8, 2020

Yes, master is still on mopidy 2.x. otherwise we could just merge develop

@ZyanKLee ZyanKLee merged commit 187c74e into master Mar 8, 2020
@s-martin s-martin deleted the Hotfix-py3-master branch March 9, 2020 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Installing RFID fails in Python script
2 participants