Added swap config on low-mem nodes #2063
Conversation
|
Hi, thanks for the PR! 🎉 could you extend/update the existing install script I agree the current name buster (which also works for bullseye) is a little bit misleading, but we would change that later. |
|
Sure thing - here you go! |
|
Little bit more on the actual change: |
More or less, yes. I don't know what else may fail in case of too less RAM. But the compile is definitely failing with 1 GB Pis. |
|
Sorry for those follow up commits - now it's done. |
|
This is done for 2 weeks now - what are we waiting for? |
There was a problem hiding this comment.
Sorry to bother again.
Some CI checks fail, see https://github.com/MiczFlor/RPi-Jukebox-RFID/actions/runs/6606776086/job/17961018222#step:6:1
I think this is because you added an additional config parameter. Could you have a look at ./scripts/installscripts/tests/run_installation_tests3.sh?
…er dialogues Made the yes/no sequence a bit easier to read Added comments, clarifying which dialogue needs an extra-Enter
|
I added some changes to both, my script additions and the testfile, which read horribly and contained plain wrong comments. I don't know why this does not re-trigger the test currently ... |
|
Hi, please add the changes from develop to the testfiile again (the line which calls the install Script). They haven't been merged entirely. |
|
Done |
|
I think you got me wrong. Now all the changes from develop are reverted. |
|
@The-Judge, I think there was some misunderstanding what @AlvinSchiller suggested (and there is a conflict). |
| # In general: If less than 2 GB RAM is available in your system, the | ||
| # build of gst-plugin-spotify will most certainly fail. | ||
| # | ||
| # This script can detect if a swapfile is required and have one |
There was a problem hiding this comment.
Is the question below, before or after the necessity for a swap file is checked?
|
|
||
| # Test installation | ||
| ./test_installation.sh $INSTALLATION_EXITCODE | ||
| ./scripts/installscripts/tests/test_installation.sh |
There was a problem hiding this comment.
Why is this change necessary?
There was a problem hiding this comment.
Thats part of the uncomplete merge and should be reverted
|
#2064 may now be obsolete (see #2064 (comment)). Therefor this PR would be obsolete as well. |
|
Obsolete with implementation of #2315 |
As discussed in #1815 (comment),
I added code which creates and activates a swap file if too few available memory is detected (less than 2 GB, which should be enough even for recent
gst-plugin-spotifybuilds).