Adapt pbc.c to current json rpc spec #1857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(somehow hacky solution)
|
Could we merge this? |
|
There is no harm with this implementation if I analyse this correctly. But the JSON RPC spec does NOT have a @sklemer1 Maybe you can help us understand where this is coming from? |
|
@pabera so it seems package is necessary, although I didn't find it in the spec |
|
It is some time since I addes this -- the reason was that the JSON from Phonie-Box used these 'package' attributes where as the cli client did not. I haven't looked into the specification -- I saw the need as ist was used in the real world implementation :). |
|
Thanks for clarification. |
s-martin
approved these changes
Dec 14, 2023
AlvinSchiller
pushed a commit
to AlvinSchiller/RPi-Jukebox-RFID
that referenced
this pull request
Jan 9, 2024
* pbc.c: add 'package' to rpc commands * pbc.c: Also recognise negative numbers as int in values (somehow hacky solution)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just added 'package' to rpc json and provided a cli option for it.