Add keybinding docs for tabSwitcher #107
Conversation
|
Docs Build status updates of commit 8c86e5a:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| TerminalDocs/new-terminal-arguments.md | View | Details | |
| TerminalDocs/customize-settings/key-bindings.md | ✅Succeeded | View |
TerminalDocs/new-terminal-arguments.md
- Line 11, Column 1: [Warning-multiple-h1s]
Multiple H1s are not allowed. You can only have one top-level heading. - Line 11, Column 1: [Suggestion-duplicate-h1s]
H1 'New Terminal Arguments in the Windows Terminal' is duplicated with other articles: 'new-terminal-arguments.md(11,1), new-terminal-arguments.md(11,1)'. First level headings must be unique within a docset. NOTE: This Suggestion will become a Warning in late September, 2020.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching in the Docs contributor and Admin Guide
- See the frequently asked questions
- Post your question in the Docs support channel
|
I think this PR is out of sync with microsoft/terminal#7321 |
|
Docs Build status updates of commit b7b4ae6:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| TerminalDocs/new-terminal-arguments.md | View | Details | |
| TerminalDocs/customize-settings/global-settings.md | ✅Succeeded | View | |
| TerminalDocs/customize-settings/key-bindings.md | ✅Succeeded | View |
TerminalDocs/new-terminal-arguments.md
- Line 11, Column 1: [Warning-multiple-h1s]
Multiple H1s(H1 'New Terminal Arguments in the Windows Terminal'(panes.md(98,1) -> new-terminal-arguments.md(11,1))) are not allowed. You can only have one top-level heading. - Line 11, Column 1: [Suggestion-duplicate-h1s]
H1 'New Terminal Arguments in the Windows Terminal' is duplicated with other articles: 'new-terminal-arguments.md(11,1), new-terminal-arguments.md(11,1)'. First level headings must be unique within a docset. NOTE: This Suggestion will become a Warning in late September, 2020.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching in the Docs contributor and Admin Guide
- See the frequently asked questions
- Post your question in the Docs support channel
|
Docs Build status updates of commit c0062cb:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| TerminalDocs/new-terminal-arguments.md | View | Details | |
| TerminalDocs/customize-settings/global-settings.md | ✅Succeeded | View | |
| TerminalDocs/customize-settings/key-bindings.md | ✅Succeeded | View |
TerminalDocs/new-terminal-arguments.md
- Line 11, Column 1: [Warning-multiple-h1s]
Multiple H1s(H1 'New Terminal Arguments in the Windows Terminal'(panes.md(98,1) -> new-terminal-arguments.md(11,1))) are not allowed. You can only have one top-level heading. - Line 11, Column 1: [Suggestion-duplicate-h1s]
H1 'New Terminal Arguments in the Windows Terminal' is duplicated with other articles: 'new-terminal-arguments.md(11,1), new-terminal-arguments.md(11,1)'. First level headings must be unique within a docset. NOTE: This Suggestion will become a Warning in late September, 2020.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching in the Docs contributor and Admin Guide
- See the frequently asked questions
- Post your question in the Docs support channel
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request This PR splits the anchored and unanchored tab switcher into two. The anchored tab switcher is now baked into `nextTab`/`prevTab`, and the unanchored tab switcher command is just named `tabSearch`. `tabSearch` takes no arguments. To reflect this distinction, `CommandPalette.cpp` now refers to one as `TabSwitchMode` and the other as `TabSearchMode`. I've added a global setting named `useTabSwitcher` (name up for debate) that makes the Terminal use the anchored tab switcher experience for `nextTab` and `prevTab`. I've also given the control the ability to detect <kbd>Alt</kbd> KeyUp events and to dispatch keybinding events. By listening for keybindings, the ATS can react to `nextTab`/`prevTab` invocations for navigation in addition to listening for <kbd>tab</kbd> and the arrow keys. Closes #7178 <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] CLA signed. * [x] Documentation updates: MicrosoftDocs/terminal#107 * [x] Schema updated.
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request This PR splits the anchored and unanchored tab switcher into two. The anchored tab switcher is now baked into `nextTab`/`prevTab`, and the unanchored tab switcher command is just named `tabSearch`. `tabSearch` takes no arguments. To reflect this distinction, `CommandPalette.cpp` now refers to one as `TabSwitchMode` and the other as `TabSearchMode`. I've added a global setting named `useTabSwitcher` (name up for debate) that makes the Terminal use the anchored tab switcher experience for `nextTab` and `prevTab`. I've also given the control the ability to detect <kbd>Alt</kbd> KeyUp events and to dispatch keybinding events. By listening for keybindings, the ATS can react to `nextTab`/`prevTab` invocations for navigation in addition to listening for <kbd>tab</kbd> and the arrow keys. Closes #7178 <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] CLA signed. * [x] Documentation updates: MicrosoftDocs/terminal#107 * [x] Schema updated.
Keybinding docs for the Advanced Tab Switcher - microsoft/terminal#6732
This should probably not go into master but into one of the release branches 😄
edit: still need to update after 7321 goes in