Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates related to removal of UWP, Xamarin, NET6-Win support in 4.61.0 #406

Merged
merged 3 commits into from
May 9, 2024

Conversation

pmaytak
Copy link
Contributor

@pmaytak pmaytak commented May 7, 2024

Fixes #395

Copy link
Contributor

Learn Build status updates of commit 6872ca0:

✅ Validation status: passed

File Status Preview URL Details
msal-dotnet-articles/acquiring-tokens/desktop-mobile/uwp.md ✅Succeeded View
msal-dotnet-articles/acquiring-tokens/desktop-mobile/wam.md ✅Succeeded View
msal-dotnet-articles/acquiring-tokens/desktop-mobile/xamarin.md ✅Succeeded View
msal-dotnet-articles/acquiring-tokens/using-web-browsers.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit f0ce12f:

✅ Validation status: passed

File Status Preview URL Details
msal-dotnet-articles/acquiring-tokens/desktop-mobile/uwp.md ✅Succeeded View
msal-dotnet-articles/acquiring-tokens/desktop-mobile/wam.md ✅Succeeded View
msal-dotnet-articles/acquiring-tokens/desktop-mobile/xamarin.md ✅Succeeded View
msal-dotnet-articles/acquiring-tokens/using-web-browsers.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit c2bee37:

✅ Validation status: passed

File Status Preview URL Details
msal-dotnet-articles/acquiring-tokens/desktop-mobile/uwp.md ✅Succeeded View
msal-dotnet-articles/acquiring-tokens/desktop-mobile/wam.md ✅Succeeded View
msal-dotnet-articles/acquiring-tokens/desktop-mobile/xamarin.md ✅Succeeded View
msal-dotnet-articles/acquiring-tokens/using-web-browsers.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

@gladjohn gladjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs an update

https://learn.microsoft.com/en-us/entra/msal/dotnet/acquiring-tokens/desktop-mobile/wam#enabling-wam

remove this If your application targets UWP or net-windows (version-dependent Target Framework Moniker for Windows), WAM is included in the MSAL.NET package.

@pmaytak
Copy link
Contributor Author

pmaytak commented May 9, 2024

this needs an update

https://learn.microsoft.com/en-us/entra/msal/dotnet/acquiring-tokens/desktop-mobile/wam#enabling-wam

remove this If your application targets UWP or net-windows (version-dependent Target Framework Moniker for Windows), WAM is included in the MSAL.NET package.

@gladjohn Yes, I specifically left it to not confuse folks on older versions. I added a comment that it's applicable to previous versions.

If your application targets UWP or net-windows (version-dependent Target Framework Moniker for Windows), WAM is included in the MSAL.NET package (applicable to versions 4.60.3 and below).

@localden localden merged commit 2be16a8 into main May 9, 2024
2 of 3 checks passed
@localden localden deleted the pmaytak/net6-win branch May 9, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the guidance on using WAM and embedded browser for net6-windows apps
3 participants