Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mount limitations documentation #1073

Merged
merged 3 commits into from
Apr 9, 2021

Conversation

guillermo
Copy link
Contributor

Mounting disk or partitions belonging to a disk that is already in use is not an option and is the cause of several issues: #5997 #6015.

This patch updates the documentation to inform about the limitations of the command, preventing future users from discovering this too late.

wsl2 mount command does not support mounting disk (or partitions belong to a disk) that is currently in use.

Reading right now the documentation, a user might think that wsl mount might be used to access a dual boot partion.
@opbld32
Copy link

opbld32 commented Feb 2, 2021

Docs Build status updates of commit 493417f:

✅ Validation status: passed

File Status Preview URL Details
WSL/wsl2-mount-disk.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@guillermo
Copy link
Contributor Author

After a comment from @OneBlue in microsoft/WSL#6015 (comment) I realize that the documentation informs about the limitations at the button of the page in the limitations section.

It felt for me as a step by a step guide. This kind of guide has limitations, and disclaimers at the beginning, from that point of view, for me this commit still makes sense. But I don't know how wide is this interpretation.

@craigloewen-msft
Copy link
Collaborator

@OneBlue please sign off and merge if the info looks good here!

Copy link
Collaborator

@OneBlue OneBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

A couple minor changes and let's merge it.

WSL/wsl2-mount-disk.md Outdated Show resolved Hide resolved
@mattwojo
Copy link
Collaborator

mattwojo commented Apr 9, 2021

Merging. Thanks @guillermo!!

@opbld31
Copy link

opbld31 commented Apr 9, 2021

Docs Build status updates of commit 3a6f109:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • [Error-RuningBuildFailed] Some unexpected errors happened when running build, please open a ticket in https://SiteHelp and include the error report for our team to troubleshoot

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@opbld30
Copy link

opbld30 commented Apr 9, 2021

Docs Build status updates of commit 62e8b01:

✅ Validation status: passed

File Status Preview URL Details
WSL/wsl2-mount-disk.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@mattwojo mattwojo merged commit e518e21 into MicrosoftDocs:master Apr 9, 2021
@guillermo guillermo deleted the wsl-mount-doc branch May 13, 2021 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants