Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in a section to cover the PopupService #332

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Add in a section to cover the PopupService #332

merged 1 commit into from
Nov 3, 2023

Conversation

bijington
Copy link
Collaborator

Aims at covering the documentation for the new popup service at: CommunityToolkit/Maui#1165

@bijington bijington marked this pull request as draft November 2, 2023 19:41
@bijington bijington requested a review from jfversluis November 2, 2023 19:42
brminnick
brminnick approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@brminnick brminnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Shaun!

@jfversluis jfversluis marked this pull request as ready for review November 3, 2023 08:35
@jfversluis jfversluis merged commit abc360e into main Nov 3, 2023
1 check passed
@jfversluis jfversluis deleted the feature/maui/add-popup-service branch November 3, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brminnick brminnick brminnick approved these changes

@jfversluis jfversluis jfversluis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bijington @jfversluis @brminnick