Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German Translation #2203

Merged
merged 29 commits into from
Aug 2, 2018
Merged

German Translation #2203

merged 29 commits into from
Aug 2, 2018

Conversation

bschley
Copy link

@bschley bschley commented Jul 19, 2018

Added a German translation for the Plugin.

Would be nice, if native Germans can give me feedback about my translation, thus we get an awesome translation.

The following is written in German and is only related to the translation itself.

--

Wenn Ihr Fehler in der Rechtschreibung findet, dann wäre es nett, die hier einfach im Comment zu erwähnen.

Zur Grammatik kann ich nur sagen, dass es bei einer Software nicht so einfach ist, der deutschen Sprache gerecht zu werden. Da muss man einige kompromisse eingehen. Daher seht meine Übersetzung als Vorschlag.

Naja immerhin... debuggen habe ich zu meinem erstaunen im Duden gefunden :D

@msftclas
Copy link

msftclas commented Jul 19, 2018

CLA assistant check
All CLA requirements met.

@@ -0,0 +1,52 @@
{
"python.command.python.sortImports.title": "Importe sortieren",
Copy link
Author

@bschley bschley Jul 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Könnte mir auch: "sortieren der Importe" vorstellen

@@ -0,0 +1,52 @@
{
"python.command.python.sortImports.title": "Importe sortieren",
"python.command.python.startREPL.title": "REPL starten",
Copy link
Author

@bschley bschley Jul 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Könnte mir auch: "starten der RETPL" vorstellen

"python.command.python.startREPL.title": "REPL starten",
"python.command.python.createTerminal.title": "Terminal erstellen",
"python.command.python.buildWorkspaceSymbols.title": "Arbeitsplatz-Symbole Erstellen",
"python.command.python.runtests.title": "Alle Unittests ausführen",
Copy link
Author

@bschley bschley Jul 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allgemein gefragt: "Unittests" oder "Unit-Tests" ? ... sehe beides sehr oft.

"python.snippet.launch.module.label": "Python: Modul",
"python.snippet.launch.module.description": "Python Modul debuggen",
"python.snippet.launch.terminal.label": "Python: Terminal (integriert)",
"python.snippet.launch.terminal.description": "Python Programm debuggen mit integrierten Terminal/Konsole",
Copy link
Author

@bschley bschley Jul 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lieber "Console" oder "Konsole" ?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit tricky:
"Python Programm debuggen mit integriertem Terminal" but "Python Programm debuggen mit integrierter Konsole" - integrierten Terminal/Konsole sounds a bit odd.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah true. Should be: Python Programm debuggen mit integriertem ... because Terminal is in front of Konsole. And integrierten was wrong.

"python.snippet.launch.externalTerminal.label": "Python: Terminal (extern)",
"python.snippet.launch.externalTerminal.description": "Python Programm mit externen Terminal/Konsole",
"python.snippet.launch.django.label": "Python: Django",
"python.snippet.launch.django.description": "Django Applikation debuggen",
Copy link
Author

@bschley bschley Jul 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lieber "Application" oder "Applikation" ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Applikation/Anwendung/g

Prefer the use of Anwendung everywhere, or keep the English word application

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, Anwendung is much nicer.

gg + Shift+V + G + :s/Applikation/Anwendung done (So mache ich das immer :D, kriege ich auch nicht mehr aus dem Kopf raus)

Copy link
Member

@berndverst berndverst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ein paar kleine Fehler, und auch Vorschläge
A few small mistakes, and also a few suggestions

"python.command.python.sortImports.title": "Importe sortieren",
"python.command.python.startREPL.title": "REPL starten",
"python.command.python.createTerminal.title": "Terminal erstellen",
"python.command.python.buildWorkspaceSymbols.title": "Arbeitsplatz-Symbole Erstellen",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Arbeitsplatz-Symbole erstellen"

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hyphened words are not very common in german - Arbeitsplatzsymbol would be a more native spelling - but then again Arbeitsplatzsymbol is super rare and is used for describing the "My Computer" Windows icon that is (was?) called Arbeitsplatz.

Copy link
Author

@bschley bschley Jul 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But in Germany is very common, that you hyphen words which are to long, to increase the readability and emphasis.

In my opinion, this is the case here. If you open something with a shortcut/hotkey you want that readability and emphasis there.

In other words, for Headlines I would write: Arbeitsplatz-Bibliotheken or Arbeitsplatz-Symbole. But in the Text itself, if I talk about these words, I wouldn't hyphen those.

"python.command.python.buildWorkspaceSymbols.title": "Arbeitsplatz-Symbole Erstellen",
"python.command.python.runtests.title": "Alle Unittests ausführen",
"python.command.python.debugtests.title": "Alle Unittests debuggen",
"python.command.python.execInTerminal.title": "Python Datei in Terminal ausfrühren",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ausführen

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer: Python Datei *im* Terminal ausführen

"python.snippet.launch.django.description": "Django Applikation debuggen",
"python.snippet.launch.flask.label": "Python: Flask (0.11.x oder neuer)",
"python.snippet.launch.flask.description": "Flask Applikation debuggen",
"python.snippet.launch.flaskOld.label": "Python: Flask (0.10.x or früher)",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.10.x oder früher

"python.snippet.launch.externalTerminal.label": "Python: Terminal (extern)",
"python.snippet.launch.externalTerminal.description": "Python Programm mit externen Terminal/Konsole",
"python.snippet.launch.django.label": "Python: Django",
"python.snippet.launch.django.description": "Django Applikation debuggen",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Applikation/Anwendung/g

Prefer the use of Anwendung everywhere, or keep the English word application

Copy link

@croth1 croth1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a native speaker but not a linguist - translating technical terms into German can be quite tricky so please take my comments with a grain of salt!

"python.command.python.sortImports.title": "Importe sortieren",
"python.command.python.startREPL.title": "REPL starten",
"python.command.python.createTerminal.title": "Terminal erstellen",
"python.command.python.buildWorkspaceSymbols.title": "Arbeitsplatz-Symbole Erstellen",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hyphened words are not very common in german - Arbeitsplatzsymbol would be a more native spelling - but then again Arbeitsplatzsymbol is super rare and is used for describing the "My Computer" Windows icon that is (was?) called Arbeitsplatz.

"python.command.python.buildWorkspaceSymbols.title": "Arbeitsplatz-Symbole Erstellen",
"python.command.python.runtests.title": "Alle Unittests ausführen",
"python.command.python.debugtests.title": "Alle Unittests debuggen",
"python.command.python.execInTerminal.title": "Python Datei in Terminal ausfrühren",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer: Python Datei *im* Terminal ausführen

"python.command.python.selectAndRunTestFile.title": "Unittest Datei ausführen ...",
"python.command.python.runCurrentTestFile.title": "Ausgewählte Unittest Datei ausführen",
"python.command.python.runFailedTests.title": "Fehlerhafte Unittests ausführen",
"python.command.python.discoverTests.title": "Unittest untersuchen",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"untersuchen" means "inspect" - is that the right word here? A more accurate translation for "discover" would be "entdecken", but Unittests entdecken sounds a bit unusual in my ears.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understood the method now I guess, so we should name it: Unittests durchsuchen

"python.snippet.launch.module.label": "Python: Modul",
"python.snippet.launch.module.description": "Python Modul debuggen",
"python.snippet.launch.terminal.label": "Python: Terminal (integriert)",
"python.snippet.launch.terminal.description": "Python Programm debuggen mit integrierten Terminal/Konsole",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit tricky:
"Python Programm debuggen mit integriertem Terminal" but "Python Programm debuggen mit integrierter Konsole" - integrierten Terminal/Konsole sounds a bit odd.

"python.snippet.launch.terminal.label": "Python: Terminal (integriert)",
"python.snippet.launch.terminal.description": "Python Programm debuggen mit integrierten Terminal/Konsole",
"python.snippet.launch.externalTerminal.label": "Python: Terminal (extern)",
"python.snippet.launch.externalTerminal.description": "Python Programm mit externen Terminal/Konsole",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mit externem Terminal, mit externer Konsole. Again to me n sounds a bit odd.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read it like this: "Python Programm mit externen Terminal oder Konsole.

I wrote now externem, because it sounds better. But for me, we are in the genitive here, thus externen should be correct.

"python.snippet.launch.pyramid.description": "Pyramid Applikation debuggen",
"python.snippet.launch.watson.label": "Python: Watson Applikation",
"python.snippet.launch.watson.description": "Watson Applikation debuggen",
"python.snippet.launch.attach.label": "Python: anhängen",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"anhängen" is a good translation for "attach", but in this context "anfügen" seems to be more common - see e.g. https://msdn.microsoft.com/de-de/library/3s68z0b3.aspx

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

"python.command.python.selectAndRunTestMethod.title": "Unittest Methode ausführen ...",
"python.command.python.selectAndDebugTestMethod.title": "Unittest Debug Methode ausführen ...",
"python.command.python.selectAndRunTestFile.title": "Unittest Datei ausführen ...",
"python.command.python.runCurrentTestFile.title": "Ausgewählte Unittest Datei ausführen",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By classical rules I would say "Unittest Datei" has to be "Unittestdatei" - In German joined compound nouns are the norm. Then again according to google "Unittestdatei" is not (yet?) a word 😕

Copy link
Author

@bschley bschley Jul 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to write: Unittest-Datei, same goes for Arbeitsplatz-Bibliotheken I only forgot it to change :)

Why I named it now Unittest-Datei and not Unittestdatei; You can see it in another comment here.

"python.command.python.setLinter.title": "Linter auswählen",
"python.command.python.enableLinting.title": "Linting aktivieren",
"python.command.python.runLinting.title": "Linting ausführen",
"python.snippet.launch.standard.label": "Python: Aktuelle Datei",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would not capitalize after the colon: Python: aktuelle Datei

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a "true" sentence so it should be "Python: Aktuelle Datei" in my opinion. Let's see what others think about that.

@codecov
Copy link

codecov bot commented Jul 24, 2018

Codecov Report

Merging #2203 into master will decrease coverage by 4.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2203      +/-   ##
==========================================
- Coverage   79.82%   75.69%   -4.13%     
==========================================
  Files         310      309       -1     
  Lines       14367    14341      -26     
  Branches     2549     2540       -9     
==========================================
- Hits        11468    10856     -612     
- Misses       2887     3475     +588     
+ Partials       12       10       -2
Flag Coverage Δ
#MacOS 73.9% <ø> (-0.1%) ⬇️
#Windows 74% <ø> (-0.11%) ⬇️
Impacted Files Coverage Δ
src/client/debugger/ProxyCommands.ts 0% <0%> (-100%) ⬇️
...c/client/debugger/DebugServers/LocalDebugServer.ts 15.09% <0%> (-56.61%) ⬇️
src/client/debugger/Main.ts 17.03% <0%> (-50.13%) ⬇️
...rc/client/debugger/PythonProcessCallbackHandler.ts 20.72% <0%> (-48.03%) ⬇️
src/client/debugger/PythonProcess.ts 11.25% <0%> (-47.92%) ⬇️
src/client/debugger/Common/TryParser.ts 21.34% <0%> (-22.48%) ⬇️
src/client/debugger/Common/Utils.ts 45.9% <0%> (-21.32%) ⬇️
src/client/debugger/DebugClients/NonDebugClient.ts 6.66% <0%> (-20%) ⬇️
...c/client/debugger/DebugClients/LocalDebugClient.ts 57.5% <0%> (-11.25%) ⬇️
src/client/ioc/container.ts 90.9% <0%> (-9.1%) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b81dea5...67d1157. Read the comment docs.

Copy link
Member

@berndverst berndverst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good enough to me now. We can forever argue about little nuances (German is hard). Let's get this out and take incremental improvements as necessary!

@berndverst
Copy link
Member

@brettcannon I think we are ready to approve and merge this

@brettcannon
Copy link
Member

@bschley could you please add a news entry thanking yourself and everyone who gave a review? Once we have that we can merge this!

@bschley
Copy link
Author

bschley commented Jul 25, 2018

Well then, for me the translation looks good and I hope the German Users likes that.

Thank you very much to the reviewers to give me support, to make this translation possible 👍 .

In Germany we say: "Four eyes see more than two"...

@bschley
Copy link
Author

bschley commented Jul 30, 2018

@brettcannon, was the news entry correct or do you want a better one? Cheers bschley

@brettcannon
Copy link
Member

@bschley there actually isn't a news entry; you just edited the README. See https://github.com/Microsoft/vscode-python/tree/master/news for instructions on how to add a news entry.

@brettcannon
Copy link
Member

And please revert the .gitignore change.

d3r3kk and others added 6 commits July 31, 2018 07:49
* LS symbol providers
* Different ready wait
* Upgrade dependencies to latest LS
* Make open files only default
* Turn off hash checks
* Fix double progress display
* Update packages
* Anchor dependencies
* Add missing mock from vscode-mock
* Downgrade pylint to < 2.0.0 to mirror prospector requirements
* Ensure Pylint<=2.0.0 on Python 2.x
* Python 2.7 requires older than 2.0.0
* tests
* Add Tests
* Fix broken tests
* Redue nesting of suites
DonJayamanne and others added 15 commits July 31, 2018 07:49
* Update to latest Language Server

- change the download version to latest build
- change the name of the executable bit of the LS

* Fix unit tests

- Remove hardcoded strings causing issues
- Expose information from downloader/platform
- Update tests for explicit OS types

* Update PIP version regex

- make it allow 2, or 3, version segments
- handles old M.m.r or new Y.r version patterns

* Remove hard-coded strings /and/ formats from tests.

* Correction to the PIP_VERSION_REGEX

- keep it simple, keeler.
* Bump version number

* Touch up news entries

* Update changelog

* 2018.7.1 release for new language server
This reverts commit b6a3098.
revert my .gitignore change
@bschley
Copy link
Author

bschley commented Aug 2, 2018

@brettcannon all done. Sorry for the delay, was a bit busy :) I hope I done the news entry like it ment to be.
Tested the output and looked good 👍

Copy link

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bschley! It's great we can incorporate this into the extension.

@d3r3kk d3r3kk merged commit 397dfd0 into microsoft:master Aug 2, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants