Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dunder variables not listed with new language server #2013

Closed
DonJayamanne opened this issue Jun 20, 2018 · 8 comments · Fixed by #2033
Closed

Dunder variables not listed with new language server #2013

DonJayamanne opened this issue Jun 20, 2018 · 8 comments · Fixed by #2033
Assignees
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@DonJayamanne
Copy link

With Jedi:
screen shot 2018-06-19 at 6 12 46 pm

With new Language Server:
screen shot 2018-06-19 at 6 13 24 pm

@qubitron @brettcannon @MikhailArkhipov
Please review and changer Milestone accordingly.

@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug needs PR labels Jun 20, 2018
@DonJayamanne DonJayamanne added this to the July 2018 milestone Jun 20, 2018
@MikhailArkhipov
Copy link

"python.autoComplete.showAdvancedMembers": true

@DonJayamanne
Copy link
Author

Shouldn't that be the default?

@MikhailArkhipov
Copy link

Are they commonly used? With all props visible user coding against their own class with 3 properties will be seeing a lot of stuff they don't care about. VS does not show those by default (unless user specifically types _). Unfortunately, there is no fine-grained control over typing in VSC.

@MikhailArkhipov MikhailArkhipov self-assigned this Jun 20, 2018
@DonJayamanne
Copy link
Author

DonJayamanne commented Jun 20, 2018

Are they commonly used?

I believe the following are commonly used:

  • __name__
  • __file__
  • __package__

VS does not show those by default (unless user specifically types _)

Why can't we display them in VSC as well, and reverse the sort order so they are displayed at the bottom. This way when users type something starting with _, then these items will appear (get filtered out)

@qubitron ?

@brettcannon
Copy link
Member

__name__ and __file__ are somewhat common, but __package__ isn't.

@qubitron
Copy link

VS does not show those by default (unless user specifically types _)

I'm confused, in this case looks like Don specifically typed _, so why wouldn't all the available dunder items appear?

@patrys
Copy link

patrys commented Jun 21, 2018

@qubitron VS in this case means Visual Studio 2017, not VSCode. It would be nice to get similar behavior in VSCode but it's not there yet.

@DonJayamanne
Copy link
Author

Decision is to enable this by default.

@brettcannon brettcannon added the area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. label Jun 21, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants