Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI errors for Code refactoring #1953

Closed
DonJayamanne opened this issue Jun 13, 2018 · 0 comments · Fixed by #1955
Closed

CI errors for Code refactoring #1953

DonJayamanne opened this issue Jun 13, 2018 · 0 comments · Fixed by #1955
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@DonJayamanne
Copy link

Refactor Rename
       Rename function in source without a trailing empty line:
      AssertionError: expected '--- a/without empty line.py\n+++ b/without empty line.py\n@@ -1,8 +1,8 @@\n import os\n \n-def one():\n+def three():\n     return True\n \n def two():\n-    if one():\n-        print("A" + one())\r\n+    if three():\n+        print("A" + three())\r\n' to equal '--- a/without empty line.py\r\n+++ b/without empty line.py\r\n@@ -1,8 +1,8 @@\r\n import os\r\n \r\n-def one():\r\n+def three():\r\n     return True\r\n \r\n def two():\r\n-    if one():\r\n-        print("A" + one())\r\n+    if three():\r\n+        print("A" + three())\r\n'
      + expected - actual
      ---- a/without empty line.py
      -+++ b/without empty line.py
      -@@ -1,8 +1,8 @@
      - import os
      - 
      --def one():
      -+def three():
      -     return True
      - 
      - def two():
      --    if one():
      +--- a/without empty line.py
      ++++ b/without empty line.py
      +@@ -1,8 +1,8 @@
      + import os
      + 
      +-def one():
      ++def three():
      +     return True
      + 
      + def two():
      +-    if one():
       -        print("A" + one())
      -+    if three():
      ++    if three():
       +        print("A" + three())
      
      at Object.<anonymous> (C:\projects\vscode-python-v3vd6\src\test\refactor\rename.test.ts:58:48)
      at Generator.next (<anonymous>)
      at fulfilled (C:\projects\vscode-python-v3vd6\out\test\refactor\rename.test.js:6:58)
      at <anonymous>
  2) Refactor Rename
       Rename function in source with a trailing empty line:
      AssertionError: expected '--- a/with empty line.py\n+++ b/with empty line.py\n@@ -1,8 +1,8 @@\n import os\n \n-def one():\n+def three():\n     return True\n \n def two():\n-    if one():\n-        print("A" + one())\n+    if three():\n+        print("A" + three())\n' to equal '--- a/with empty line.py\r\n+++ b/with empty line.py\r\n@@ -1,8 +1,8 @@\r\n import os\r\n \r\n-def one():\r\n+def three():\r\n     return True\r\n \r\n def two():\r\n-    if one():\r\n-        print("A" + one())\r\n+    if three():\r\n+        print("A" + three())\r\n'
      + expected - actual
      ---- a/with empty line.py
      -+++ b/with empty line.py
      -@@ -1,8 +1,8 @@
      - import os
      - 
      --def one():
      -+def three():
      -     return True
      - 
      - def two():
      --    if one():
      --        print("A" + one())
      -+    if three():
      -+        print("A" + three())
      +--- a/with empty line.py
      ++++ b/with empty line.py
      +@@ -1,8 +1,8 @@
      + import os
      + 
      +-def one():
      ++def three():
      +     return True
      + 
      + def two():
      +-    if one():
      +-        print("A" + one())
      ++    if three():
      ++        print("A" + three())
      
      at Object.<anonymous> (C:\projects\vscode-python-v3vd6\src\test\refactor\rename.test.ts:70:48)
      at Generator.next (<anonymous>)
      at fulfilled (C:\projects\vscode-python-v3vd6\out\test\refactor\rename.test.js:6:58)
      at <anonymous>

@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug needs PR labels Jun 13, 2018
@DonJayamanne DonJayamanne added this to the June 2018 milestone Jun 13, 2018
@DonJayamanne DonJayamanne self-assigned this Jun 13, 2018
DonJayamanne added a commit that referenced this issue Jun 14, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant