Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster node unit tests #12027

Merged
merged 3 commits into from
May 28, 2020
Merged

Faster node unit tests #12027

merged 3 commits into from
May 28, 2020

Conversation

DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented May 27, 2020 •
edited
Loading

For #11999

  • When running unit tests we don't need to compile the webviews (no need to compile react, etc).
  • Total time to compile code down from 6 minutes to 1 minute (i.e. 5 minutes faster CI to know whether tests passed/failed)

Note the drop in compile times from ~7minutes to ~50s. (basically 6 minutes faster)

Before After
Screen Shot 2020-05-27 at 16 31 19 Screen Shot 2020-05-27 at 16 31 34

@DonJayamanne DonJayamanne marked this pull request as ready for review May 27, 2020 23:53
@sonarcloud
Copy link

sonarcloud bot commented May 28, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DonJayamanne DonJayamanne merged commit d4749aa into microsoft:master May 28, 2020
@DonJayamanne DonJayamanne deleted the fasterNodeUnitTests branch May 28, 2020 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidKutu DavidKutu DavidKutu approved these changes

@rchiodo rchiodo rchiodo approved these changes

@karthiknadig karthiknadig karthiknadig approved these changes

@IanMatthewHuff IanMatthewHuff Awaiting requested review from IanMatthewHuff

@greazer greazer Awaiting requested review from greazer

@joyceerhl joyceerhl Awaiting requested review from joyceerhl

@techwithtim techwithtim Awaiting requested review from techwithtim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DonJayamanne @karthiknadig @rchiodo @DavidKutu