Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pipenv install --dev for formatters, linters, etc... #1110

Closed
Varkal opened this issue Mar 17, 2018 · 1 comment · Fixed by #1134
Closed

Use pipenv install --dev for formatters, linters, etc... #1110

Varkal opened this issue Mar 17, 2018 · 1 comment · Fixed by #1134
Assignees
@DonJayamanne
Labels
feature-request Request for new features or functionality
Milestone
March 2018

Comments

@Varkal
Copy link

Varkal commented Mar 17, 2018 •
edited
Loading

Environment data

  • VS Code version: 1.21.1
  • Extension version (available under the Extensions sidebar): 2018.2.1
  • OS and version: macOS 10.12.6
  • Python version (& distribution if applicable, e.g. Anaconda): 3.6.4
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): pipenv

Actual behavior

VSCode prompt for installation of linters, formatters etc... when needed and install them with

pipenv install <stuff>

Expected behavior

It will be better if the extension use the --dev flag for this kind of stuff

pipenv install <stuff> --dev

because, we don't want to install autopep8 or rope in production ;-)
@DonJayamanne DonJayamanne added feature-request Request for new features or functionality needs PR labels Mar 17, 2018
@brettcannon
Copy link
Member

I actually didn't think we had added the pipenv install support. 😄 But yes, we should be using --dev.

@brettcannon brettcannon added this to the March 2018 milestone Mar 19, 2018
@DonJayamanne DonJayamanne self-assigned this Mar 21, 2018
@DonJayamanne DonJayamanne mentioned this issue Mar 21, 2018
Merged
5 tasks
DonJayamanne added a commit that referenced this issue Mar 21, 2018
@DonJayamanne
When using pipenv, install packages (such as linters, test frameworks…
7c3ff8a 
…) in dev-packages

Fixes #1110
@lock lock bot locked as resolved and limited conversation to collaborators Jul 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
feature-request Request for new features or functionality
Projects
None yet
Milestone
March 2018
3 participants
@brettcannon @DonJayamanne @Varkal