This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Do not allow import for already imported pkgs #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
force-pushed
the
unused-imports
branch
2 times, most recently
from
860ba1a to
5fc0a2e
Compare
ramya-rao-a
force-pushed
the
unused-imports
branch
from
5fc0a2e to
27f7681
Compare
Tyriar
approved these changes
Oct 6, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #494
In this PR, while returning list of packages that can be imported,
go-outlinetool is run on the file to get list of already imported packages so that the list returned by theGo: Add Importcommand can be filteredSince we only need to parse the file for imports, parsing the whole file is unnecessary.
lukehoban/go-outline#4 adds the option to parse for imports only to the go-outline tool. Once that PR is merged, we can make use of the "parse imports only" feature