added listAccountSas TLE #125
Conversation
assets/ExpressionMetadata.json
Outdated
| { | ||
| "name": "listKeys", | ||
| "expectedUsage": "listKeys(resourceName\/resourceIdentifier, apiVersion)", | ||
| "expectedUsage": "listKeys(resourceId, apiVersion)", |
There was a problem hiding this comment.
Why these changes? The API specifically lists the argument as resource name or ID:
https://docs.microsoft.com/en-us/azure/azure-resource-manager/resource-group-template-functions-resource#list
There was a problem hiding this comment.
resourceId is correct, resourceName is shorthand. The definitions were inconsistent and I may have over simplified - don't have a strong opinion (other than to be consistent).
There was a problem hiding this comment.
The question is, can you pass in just a resource name and have it work? If no, stick with resourceId, thanks.
There was a problem hiding this comment.
I'm guessing the test failures are due to the resourceName/Id change. The unit tests are over testing right now - I've loosened it up a bit but not enough. Do you want me to handle fixing them?
There was a problem hiding this comment.
I reverted the change (and made the last one consistent) - so that should be back to previous behavior... let's see what happens.
There was a problem hiding this comment.
So can you actually pass in just the resource name?
There was a problem hiding this comment.
you can - provided that resource is defined in the template... if not, then you need the fulll resourceId.
| "maximumArguments": 3, | ||
| "returnValueMembers": [ | ||
| { | ||
| "name": "accountSasToken" |
There was a problem hiding this comment.
Not sure this is correct. Does it return an object with a accountSasToken property (as you have here), or does it simply return the account SAS token? Thx.
There was a problem hiding this comment.
It returns an object with exactly one property named accountSasToken
|
Thanks, Brian. |
|
thx for fixing the tests ;) |
No description provided.