Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

no-backbone-get-set-outside-model has obscenely long rule warnings #662

Closed
JoshuaKGoldberg opened this issue Dec 3, 2018 · 0 comments · Fixed by #663
Closed

no-backbone-get-set-outside-model has obscenely long rule warnings #662

JoshuaKGoldberg opened this issue Dec 3, 2018 · 0 comments · Fixed by #663
Assignees
Labels
Difficulty: Easy Someone with little to no experience in TSLint should be able to send a pull request for this issue. Good First Issue 🙌 Howdy, neighbor! Status: Accepting PRs Type: Bug
Milestone

Comments

@JoshuaKGoldberg
Copy link

Bug Report

  • tslint-microsoft-contrib version: 6.0.0
  • TSLint version: 5.11.0
  • TypeScript version: 3.1.2
  • Running TSLint via: CLI

TypeScript code being linted

var datetime = model.get('timestamp');

// ...more code

with tslint.json configuration:

{
    "rules": {
        "no-backbone-get-set-outside-model": [true]
    }
}

Actual behavior

Rule failure should just be that one line

Expected behavior

In the rule's source:

this.addFailureAt(node.getStart(), node.getEnd(), msg);

node.getEnd() is passed to the width parameter of this.addFailureAt, so the length increases the further done the file the failure is. Lol.

Found as part of #489 - good reinforcement of why the TSLint test migration is good!

@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Dec 3, 2018
@JoshuaKGoldberg JoshuaKGoldberg added Type: Bug Status: Accepting PRs Good First Issue 🙌 Howdy, neighbor! Difficulty: Easy Someone with little to no experience in TSLint should be able to send a pull request for this issue. labels Dec 3, 2018
JoshuaKGoldberg pushed a commit that referenced this issue Dec 3, 2018
@IllusionMH IllusionMH added this to the 6.1.0-beta milestone Feb 19, 2019
apawast pushed a commit to lupine86/tslint-microsoft-contrib that referenced this issue Feb 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Difficulty: Easy Someone with little to no experience in TSLint should be able to send a pull request for this issue. Good First Issue 🙌 Howdy, neighbor! Status: Accepting PRs Type: Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants