Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

no-http-string rule - false positive when http:// occurs in the middle of a string #338

Closed
JoshuaKGoldberg opened this issue Jan 24, 2017 · 0 comments
Closed

no-http-string rule - false positive when http:// occurs in the middle of a string #338

JoshuaKGoldberg opened this issue Jan 24, 2017 · 0 comments
Assignees
@HamletDRC
Milestone
4.0.1

Comments

@JoshuaKGoldberg
Copy link

description: 'Do not use strings that start with \'http:\'. URL strings should start with \'https:\'. ',

The regex used is /.*http:.*/, not /^http:.*/.
@HamletDRC HamletDRC self-assigned this Feb 2, 2017
@HamletDRC HamletDRC added this to the 3.0.1 milestone Feb 2, 2017
@HamletDRC HamletDRC changed the title no-http-string's description says "start", but it checks for any no-http-string rule - false positive when http:// occurs in the middle of a string Mar 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HamletDRC HamletDRC

Labels
None yet
Projects
None yet
Milestone
4.0.1
Development

No branches or pull requests
2 participants
@HamletDRC @JoshuaKGoldberg