Wrong WebGLRenderingContext interface definition for pixelStorei

[SpaceIm]

TypeScript Version: 3.1.1

Search Terms:
WebGLRenderingContext
pixelStorei

Code

gl.pixelStorei(gl.UNPACK_FLIP_Y_WEBGL, true);

Expected behavior:
well compiled

Actual behavior:
TS2345: Argument of type 'true' is not assignable to parameter of type 'number'.

pixelStorei definition in lib.dom.d.ts (in 3.1-rc and 3.1.1) :

pixelStorei(pname: GLenum, param: GLint): void;

should be :

pixelStorei(pname: GLenum, param: GLint | GLboolean): void;

In 3.0.3, pixelStorei definition was :

pixelStorei(pname: number, param: number | boolean): void;

[andrewvarga]

Out of curiosity, I wonder how this could creep back in a second time?
#13093

[dakom]

What is the recommended workaround until this is fixed? Not sure how to override this locally..

[davidmaceachern]

Created a pull request to fix #28591.

[mofogasy]

@dakom as a workaround we use 0 for false and 1 for true, not a 100% sure though if it works correctly

[SpaceIm]

@dakom as a workaround we use 0 for false and 1 for true, not a 100% sure though if it works correctly

It works, and you can also convert boolean to a number.

gl.pixelStorei(gl.UNPACK_FLIP_Y_WEBGL, true); // error TS2345
gl.pixelStorei(gl.UNPACK_FLIP_Y_WEBGL, 1); // ok
gl.pixelStorei(gl.UNPACK_FLIP_Y_WEBGL, +true); // ok

gl.pixelStorei(gl.UNPACK_FLIP_Y_WEBGL, false); // error TS2345
gl.pixelStorei(gl.UNPACK_FLIP_Y_WEBGL, 0); // ok
gl.pixelStorei(gl.UNPACK_FLIP_Y_WEBGL, +false); // ok