Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DietPi-Software | TasmoAdmin: Fixe firmware restriction error #6328

Merged
merged 2 commits into from
May 2, 2023
Merged

DietPi-Software | TasmoAdmin: Fixe firmware restriction error #6328

merged 2 commits into from
May 2, 2023

Conversation

SimonPHP
Copy link
Contributor

Tasmoadmin could not deploy update to clients because the /tasmoadmin/data/firmwares directory had restricted access. Additionally, the path given in this file was wrong. /tasmoadmin/firmwares doesn't exist.

@MichaIng MichaIng changed the base branch from master to dev April 21, 2023 14:27
@MichaIng MichaIng changed the base branch from dev to master April 21, 2023 14:27
@MichaIng
Copy link
Owner

MichaIng commented Apr 21, 2023 •
edited
Loading

Many thanks for your contribution.

Could you rebase or recreate the PR against dev branch please?

And we should sync this change with Apache and Lighttpd webserver configs.

Looks like there is more we could/should update:

@MichaIng MichaIng added this to the v8.17 milestone Apr 21, 2023
@MichaIng MichaIng self-requested a review April 21, 2023 14:43
@SimonPHP @MichaIng
Fixed restriction error
1b69e79 
Tasmoadmin could not deploy update to clients because the `/tasmoadmin/data/firmwares` directory had restricted access. Additionally, the path given in this file was wrong. `/tasmoadmin/firmwares` doesn't exist.
@MichaIng MichaIng changed the base branch from master to dev May 2, 2023 18:27
@MichaIng
v8.17
ff87bc0 
- DietPi-Software | TasmoAdmin: Grant access to firmwares for Lighttpd as well, align comments and make syntax slightly more efficient, using "^~" prefix+stop operator on Nginx for the firmwares path
@MichaIng
Copy link
Owner

MichaIng commented May 2, 2023 •
edited
Loading

@SimonPHP
Could you give it a try with the commit I just applied? I'm testing it on VM as well:

  • Apache
  • Nginx
  • Lighttpd

MichaIng
MichaIng approved these changes May 2, 2023
View reviewed changes
Copy link
Owner

@MichaIng MichaIng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me on all webservers.

@MichaIng MichaIng changed the title Fixed restriction error DietPi-Software | TasmoAdmin: Fixe firmware restriction error May 2, 2023
@MichaIng
Copy link
Owner

MichaIng commented May 2, 2023

I'll merge this now. However, would be great if you could test it. I can only test via browser but not with actual clients.

@MichaIng MichaIng merged commit 1729d16 into MichaIng:dev May 2, 2023
@MichaIng MichaIng mentioned this pull request May 2, 2023
Merged
@SimonPHP
Copy link
Contributor Author

SimonPHP commented May 2, 2023

Hey, nice that you are so active, i have little time at the moment. I hope i get to it next week.

disconn3ct added a commit to disconn3ct/DietPi that referenced this pull request May 3, 2023
@disconn3ct
Merge branch 'dev' into feat/ipvs
0f2a562 
* dev: (75 commits)
  v8.17 (MichaIng#6362)
  v8.17
  v8.17 (MichaIng#6328)
  v8.17
  v8.17 (MichaIng#6356)
  v8.17
  v8.17
  v8.17
  v8.17
  v8.17 (MichaIng#6355)
  v8.17
  v8.17
  v8.17 (MichaIng#6353)
  v8.17
  v8.17
  v8.17
  v8.17 (MichaIng#6339)
  v8.17 (MichaIng#6303)
  v8.17
  v8.17
  ...
This was referenced May 5, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaIng MichaIng MichaIng approved these changes

Assignees

@SimonPHP SimonPHP

Labels
Bug 🐞
Projects
None yet
Milestone
v8.17
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonPHP @MichaIng