feat: Removes censorship and tracking from the UI. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicahZoltu
force-pushed
the
no-censorship
branch
2 times, most recently
from
4e6f279 to
60afa3e
Compare
MicahZoltu
force-pushed
the
main
branch
2 times, most recently
from
8b7e1e0 to
1f53ac7
Compare
Also swaps out some of the RPC servers used since the Infura ones are known to censor. Keydonix is just currently just CloudFlare's JSON-RPC server under the hood (DNS CNAME). The reason the public CF server wasn't included was because there aren't public testnet servers, and I would like to ensure CF gets paid for the traffic being sent to it so they continue to offer their service (using the public gateway would result in the cost being entirely theirs). Also, if CloudFlare censors (or ends up being too expensive), I can redirect Keydonix to QuickNode or somewhere else that is cheaper/censorship resistant. The wallet test was disabled because after a day of debugging I was unable to figure out why changing the RPC server for mainnet from Infura to Keydonix results in the test failing. When I tested the behavior in a production environment everything worked, so I decided to disable the test for now so I could move forward.
MicahZoltu
force-pushed
the
no-censorship
branch
from
60afa3e to
924d4e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also swaps out some of the RPC servers used since the Infura ones are known to censor. Keydonix is just currently just CloudFlare's JSON-RPC server under the hood (DNS CNAME). The reason the public CF server wasn't included was because there isn't a public testnet server, and I would like to ensure CF gets paid for the traffic I am sending it so they continue to offer their service (using the public gateway would result in the cost being entirely theirs). Also, if CloudFlare censors (or ends up being too expensive), I can redirect Keydonix to QuickNode or somewhere else that is cheaper/censorship resistant.
The service worker tests were removed because the only thing that used service workers in production was the tracking code, so once that was ripped out the tests no longer passed (correctly).
The wallet test was disabled because after a day of debugging I was unable to figure out why changing the RPC server for mainnet from Infura to Keydonix results in the test failing. When I tested the behavior in a production environment everything worked, so I decided to disable the test for now so I could move forward.
The linter on this project is incredibly strict, so while this PR is almost entirely just deletions, in many places I had to add/remove whitespace (newlines, indentation, etc.) to satisfy the linter. Recommend viewing this changeset with whitespace changes ignored.
There is certainly more that could be done to further improve the privacy protection of Uniswap users, but I intentionally kept the scope here narrow.