feat: add age plugin and fido2 hmac support #680
Conversation
|
Nice. Should we also point to your sops changes? |
| description = '' | ||
| List of plugins to use for sops decryption. | ||
| ''; | ||
| }; |
There was a problem hiding this comment.
Doesn't that also require age plugin support in sops?
There was a problem hiding this comment.
I don't follow.
We should probably add the fido2-hmac plugin as a default in this option though.
There was a problem hiding this comment.
Do we not need sops-nix to recognise these age plugin style age keys to not fail to run, even if they are not used?
This points to my patched version of |
|
To be quite honest I just looked at your PR and adapted it to use my sops. Maybe there's some extra steps missing here. |
|
Line 8 in 53c853f |
|
I'll have a proper look rather than just copy pasta. |
|
@brianmcgee what is the current status? |
|
@OliverGeneser hoping to finish this during the holidays. |
|
Replying to this quote from the previous PR
That sounds to me like it's one or the other? Or at least a plugin needs to be explicitly supported? Is it possible to support both? For those of us already using the yubikey plugin (there are many I think because that plugin predates the FIDO2 one) that would be really great! Edit: and thanks @Mic92 and @brianmcgee for all your efforts getting this feature supported in sops, I saw it hasn't been straightforward and also required changes to age. ❤️ |
brianmcgee
force-pushed
the
feat/age-plugins
branch
from
faef2bd to
93bdb70
Compare
brianmcgee
force-pushed
the
feat/age-plugins
branch
from
93bdb70 to
268afb1
Compare
| go 1.18 | ||
| go 1.22 | ||
|
|
||
| toolchain go1.23.3 |
There was a problem hiding this comment.
Please drop that otherwise go while whine about toolchaik incompatibles and create useless friction.
| mkdir -p $out/bin | ||
| makeWrapper ${age}/bin/age $out/bin/age \ | ||
| --prefix PATH : ${lib.makeBinPath [ age-plugin-fido2-hmac ]} | ||
| '' |
There was a problem hiding this comment.
We want a final newline here
| mkdir -p $out/bin | ||
| makeWrapper ${sops}/bin/sops $out/bin/sops \ | ||
| --prefix PATH : ${lib.makeBinPath [ age-plugin-fido2-hmac ]} | ||
| '' |
There was a problem hiding this comment.
Same here and the next file
| version = "age-sops"; | ||
|
|
||
| src = fetchFromGitHub { | ||
| owner = "age-sops"; |
There was a problem hiding this comment.
That should be just two spaces
No description provided.