Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for updating yarn FOD hash #68

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

yu-re-ka
Copy link
Contributor

@yu-re-ka yu-re-ka commented Oct 8, 2021

@Mic92
Copy link
Owner

Mic92 commented Oct 9, 2021

I am ok with merging this features once we have it in nixpkgs. Please also update our feature section: https://github.com/Mic92/nix-update#features

@Mic92
Copy link
Owner

Mic92 commented Nov 22, 2022

Are you still working on this?

@yu-re-ka yu-re-ka marked this pull request as ready for review September 6, 2023 10:25
@yu-re-ka
Copy link
Contributor Author

yu-re-ka commented Sep 6, 2023

@Mic92 @figsoda rebased, added feature note in the readme. this should be ready.

@figsoda
Copy link
Collaborator

figsoda commented Sep 6, 2023

Do you have an example where this works? It doesn't seem to work with mkYarnPackage because the version attribute always seems to be in .../yarn2nix-moretea/yarn2nix/default.nix

Copy link
Collaborator

@figsoda figsoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I saw the gotify PR, lgtm

@figsoda figsoda merged commit 8e3c8af into Mic92:master Sep 6, 2023
3 checks passed
@yu-re-ka yu-re-ka deleted the feature/yarn-hash branch September 9, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants