Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix handling of cargo.lock outside a workspace #273

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

natsukium
Copy link
Contributor

This is a follow-up PR for #266.

If Cargo.toml is outside a workspace, Cargo.lock is generated in the same directory as Cargo.toml.

The current implementation expects Cargo.lock to be in the project root, so the update fails.
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpn_dgfq0d/Cargo.lock'

`--extra-experimental-features` is included in `opts.extra_flags`
if Cargo.toml is outside a workspace, Cargo.lock is generated in the
same directory as Cargo.toml
@Mic92
Copy link
Owner

Mic92 commented Aug 21, 2024

@mergify queue

Copy link
Contributor

mergify bot commented Aug 21, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 737121e

@mergify mergify bot merged commit 737121e into Mic92:master Aug 21, 2024
6 checks passed
@natsukium natsukium deleted the fix/generate-cargolock branch August 21, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants