Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for updating pnpmDeps #255

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

Scrumplex
Copy link
Contributor

Now that NixOS/nixpkgs#290715, it would be nice to have some update tooling :D

You can test this with the package pot, as it is one patch version behind on master.

https://github.com/pot-app/pot-desktop/releases

@SuperSandro2000
Copy link
Collaborator

Can we add a test for it?

@Scrumplex
Copy link
Contributor Author

I actually have one in my local tree, but as the PR in question hasn't hit nixpkgs-unstable yet, I wasn't able to run it.

@Mic92
Copy link
Owner

Mic92 commented Jun 6, 2024

@mergify rebase

Copy link
Contributor

mergify bot commented Jun 6, 2024

rebase

✅ Branch has been successfully rebased

@Mic92
Copy link
Owner

Mic92 commented Jun 7, 2024

I plan to publish a new version soon, in case you want to add this one as well.

@Scrumplex
Copy link
Contributor Author

The pnpm tooling is still not in nixpkgs-unstable yet, so I can't add a test for it yet :O

https://nixpk.gs/pr-tracker.html?pr=290715

@Mic92
Copy link
Owner

Mic92 commented Jun 8, 2024

Looks like it's now in nixpkgs-unstable.

@Scrumplex Scrumplex force-pushed the feat/update-pnpm-deps branch 2 times, most recently from 997af6f to 268e4c3 Compare June 8, 2024 09:48
@Scrumplex
Copy link
Contributor Author

Scrumplex commented Jun 8, 2024

This should be ready to review and merge!

I also made the tests use the Nixpkgs pinned in the flake when using the default devShell.

@Mic92
Copy link
Owner

Mic92 commented Jun 11, 2024

@mergify queue

Copy link
Contributor

mergify bot commented Jun 11, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at dffbb9f

@mergify mergify bot merged commit dffbb9f into Mic92:master Jun 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants