Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to go-modules.outputHash #150

Merged
merged 1 commit into from
Apr 10, 2023
Merged

switch to go-modules.outputHash #150

merged 1 commit into from
Apr 10, 2023

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Apr 9, 2023

No description provided.

@figsoda
Copy link
Collaborator

figsoda commented Apr 9, 2023

we should probably keep this around for a little longer because people do use nix-update outside nixpkgs

@zowoq
Copy link
Contributor Author

zowoq commented Apr 9, 2023

we should probably keep this around for a little longer because people do use nix-update outside nixpkgs

This'll be necessary as otherwise nix-update won't work with nixpkgs as vendorSha256 == vendorHash.

We've already broken prior compatibility once when we added vendorHash and _unset.

This PR should actually restore that compatibility but I don't think it's worth the hassle to trying to keep this around as well.

@figsoda
Copy link
Collaborator

figsoda commented Apr 9, 2023

This'll be necessary as otherwise nix-update won't work with nixpkgs as vendorSha256 == vendorHash.

Understandable then :) I wasn't aware of that

Would using go-modules.outputHash perhaps be more compatible?

@zowoq
Copy link
Contributor Author

zowoq commented Apr 9, 2023

Would using go-modules.outputHash perhaps be more compatible?

iirc it didn't work when vendorHash was first added here but it does work now.

@zowoq zowoq changed the title remove vendorSha256 switch to go-modules.outputHash Apr 9, 2023
@zowoq zowoq marked this pull request as ready for review April 9, 2023 21:19
@figsoda
Copy link
Collaborator

figsoda commented Apr 10, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 10, 2023

Build succeeded:

@bors bors bot merged commit 71e0c96 into master Apr 10, 2023
@figsoda figsoda deleted the go-vendor branch April 10, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants