-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SonarQube Endpoint #8
SonarQube Endpoint #8
Conversation
This cmdlet requires that you install an extension. It just so happens on my test account I don't have it installed and you get a less that useful error message. Can you uninstall the extension from an account and test? That way you can add better error handling to tell the user which extension they need to install. At a minimum that needs to be in the help. Second suggestion is make the token secured if entered from the prompts. Look at the Add-TeamAccount as an example. There you can provide the PAT two ways. One way as plain text good for use in scripts and one way as a Secure String good for use of interactive sessions. |
So:
|
Correct. With the token you should be able to pass it in either as a plain text as a command line arg or as a secure string if PowerShell prompts for it. Add-TeamAccount does this with the PAT. |
Hi @DarqueWarrior, better? |
Without a Default set I was getting 'Parameter set cannot be resolved using the specified named parameters.' Added url of extension to error message This way people would know where to download the requirements. Changed parameter name in Add-TeamAccount to match yours. Your name choice made it much clearer which to use on the command line.
The Sonarqube Endpoint is a like a generic endpoint with the type "sonarqube" We can easily add a generic endpoint from this base but I think a refactoring should be welcomed to avoid code duplication.