-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service endpoint handling #50
Service endpoint handling #50
Conversation
Please provide some feedback if these functions are going into the right direction and if the generic service handling is ok |
Sorry for the delay. I had to fly overseas. I will try to find time to review this week. Thank you so much for your support. |
I'm currently testing it and it works great :) I still want to update all other specific functions (kubernetes, azurerm, sonarqube) so that they use |
Sorry for the delay we are all heads down getting ready for build conference next week. Once that is behind me I will work on merging your changes. Thanks for your patience and support. |
Any progress? |
When I try and run the unit tests I get this.
There also seems to be a copy and paste error here the test is VSTeam Service Endopoint but the test is SonarQube.
I should not have to provide any values during the execution of your tests. This will break the CI system where you can't provide the values. |
- Add kubernetes handling - Add general endpoint creation
Rebased and squashed branch PS: Is the test failure because of my commits? Currently not sure... |
I noticed the help says that generatePfx and acceptUntrustedCerts are SwitchParameters but they are boolean which are not the same. Boolean requires you to pass $true or $false where a switch is off by default and true if present. I prefer switch parameters and will be changing them. So this will be a breaking change and I will adjust the version number to indicate that. Anywhere you have -generatePfx $true can be changed to -generatePfx anywhere you have -generatePfx $false The parameter can simply be removed from the call. |
PR Summary
Adds functions to handle generic and kubernetes endpoints and also a function to update generic endpoints. Will be used for automated creation and maintenance of services endpoints in VSTS.
Add
Add-VSTeamKubernetesEndpoint
Add
Add-VSTeamServiceEndpoint
Add
Update-VSTeamServiceEndpoint
PR Checklist