enable API version 6.0 for Get-VSTeamUserEntitlement #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added unit tests for /Get-VSTeamUserEntitlement * updated documentation
mnieto
commented
Mar 2, 2022
SebastianSchuetze
requested changes
Mar 16, 2022
There was a problem hiding this comment.
Really great code as a first contributor!
Not so sure about the solution how you try to check API difference by using count of parameters. Which seems more of a work around.
Wondering if we could solve it by using dynamic parameters and trying to resolve parameters that are shown by evaluating the set apiVersion. The version is always set, and we should make use of it and create the dependency from there.
|
@SebastianSchuetze , I sent my comments regarding to the _countParameters function. What direction should I get? |
7 tasks
SebastianSchuetze
approved these changes
Sep 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Allows to take advantage of the filter parameter defined in the API v6.0
Defines a new parameterset specific for v6.0 onwards, and ensure that the existing top and skip parameters only can be executed with lower API versions
Fix #388
PR Checklist