-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added breaking change warning and new version notification on module load #440
Added breaking change warning and new version notification on module load #440
Conversation
@DarqueWarrior what do you think of this? I found a way that is cheaper than checking PS Gallery. We go directly to GitHub and that is fast enough to check on every module load: |
Also do you think the warning message is enough or should I not add this hard coded? |
I just need to find a way that this is not called during unit tests. Seems to stress the rate limit of the GitHub API too much. 😆 |
Have you tried putting this in the psm1 file instead of calling it on every web request that should only be run when the module is loaded. |
It is in the psm1 file 🙂. But unit tests seem to load the whole module several times. But I got an idea. Maybe I offer an option with an environment variable that is checked with boolean. So people can turn of the warning. And also the update notification. |
- moved custom message to function
- truned it of during pipeline unit tests
- improved _showModuleLoadingMessages
Added new issue templates for bug reports and feature requests
* optimized readme file * updated link directly to the pages instead of section * minor tweaks for links * anker mistake fix
- moved custom message to function
- truned it of during pipeline unit tests
- improved _showModuleLoadingMessages
…com/MethodsAndPractices/vsteam into topic/addModuleLoadingNotifications
Added notification message if a new version is abailable.
Added warning message for upcoming changes in #438