Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added breaking change warning and new version notification on module load #440

Merged
merged 54 commits into from
Feb 21, 2022

Conversation

SebastianSchuetze
Copy link
Collaborator

Added notification message if a new version is abailable.

Added warning message for upcoming changes in #438

@SebastianSchuetze
Copy link
Collaborator Author

@DarqueWarrior what do you think of this?

I found a way that is cheaper than checking PS Gallery. We go directly to GitHub and that is fast enough to check on every module load:

image

@SebastianSchuetze
Copy link
Collaborator Author

Also do you think the warning message is enough or should I not add this hard coded?

@SebastianSchuetze
Copy link
Collaborator Author

I just need to find a way that this is not called during unit tests. Seems to stress the rate limit of the GitHub API too much. 😆

@DarqueWarrior
Copy link
Collaborator

Have you tried putting this in the psm1 file instead of calling it on every web request that should only be run when the module is loaded.

@SebastianSchuetze
Copy link
Collaborator Author

SebastianSchuetze commented Jan 14, 2022

It is in the psm1 file 🙂. But unit tests seem to load the whole module several times.

But I got an idea. Maybe I offer an option with an environment variable that is checked with boolean.

So people can turn of the warning. And also the update notification.

@SebastianSchuetze SebastianSchuetze marked this pull request as ready for review February 21, 2022 15:35
@SebastianSchuetze SebastianSchuetze merged commit 682186d into trunk Feb 21, 2022
@SebastianSchuetze SebastianSchuetze deleted the topic/addModuleLoadingNotifications branch February 21, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants