Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Update-VSTeamUserEntitlement to correctly use contentype application/json-patch+json #430

Merged
merged 7 commits into from
Jan 10, 2022

Conversation

thahif
Copy link
Contributor

@thahif thahif commented Nov 22, 2021

@thahif
Copy link
Contributor Author

thahif commented Nov 23, 2021

@SebastianSchuetze - PR raised. Can you take it fwd from here?

@SebastianSchuetze SebastianSchuetze changed the title Updated contentType to application/json-patch+json Updated Update-VSTeamUserEntitlement to correctly use contentype application/json-patch+json Nov 23, 2021
@SebastianSchuetze SebastianSchuetze linked an issue Nov 23, 2021 that may be closed by this pull request
4 tasks
@SebastianSchuetze
Copy link
Collaborator

@thahif could you check that you allowed me to make updates in your branch as a maintainer?

Otherwise you would need to update the changelog.md in the same way like the other entries. Your change would fit in version 7.5.0

image

@thahif
Copy link
Contributor Author

thahif commented Nov 23, 2021

@SebastianSchuetze - I see that you can edit my branch.

image

@SebastianSchuetze
Copy link
Collaborator

Strange. I can't edit the branch.

@thahif
Copy link
Contributor Author

thahif commented Nov 29, 2021

@SebastianSchuetze - what do we next? I have re-applied that allow edit by maintainers permission. Can you please check?

@SebastianSchuetze
Copy link
Collaborator

If not then I will use your branch in one of mine and merge that one. This I would close then.

@thahif
Copy link
Contributor Author

thahif commented Nov 29, 2021

@SebastianSchuetze - Any timeline that you can comment when this will be available to download?

@SebastianSchuetze
Copy link
Collaborator

I will try my best but first I need to solve this #424 and it is usually happening outside of my worktime. So no ETA I can only try to give my best. Even if I merge it it will not be available before release works.

@SebastianSchuetze
Copy link
Collaborator

But you might want to check the cmdlet Invoke-VSTeamRequest which allows you to address any API of AzDO with your own custom JSON body. In that way you might have a work around in the mean time.

You just need to handle the API yourself a bit. Or even copy the code and reuse it with this command.

@SebastianSchuetze SebastianSchuetze self-requested a review January 10, 2022 20:19
@SebastianSchuetze SebastianSchuetze changed the title Updated Update-VSTeamUserEntitlement to correctly use contentype application/json-patch+json Fix Update-VSTeamUserEntitlement to correctly use contentype application/json-patch+json Jan 10, 2022
@SebastianSchuetze
Copy link
Collaborator

I solved finally the problem with the workflow.... or at least nearly. I will be working on your PR and merge it as soon as possible.

@SebastianSchuetze SebastianSchuetze merged commit b649e51 into MethodsAndPractices:trunk Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update-VSTeamUserEntitlement not working to update user acesslevel
2 participants