Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Billing Cmdlets Optimized #389

Merged

Conversation

SebastianSchuetze
Copy link
Collaborator

PR Summary

updated changed made with PR #371

what has changed:

  • funnily it seems that the team changed the API. now they use a proper dev.azure.com domain and unified billing api endpoint. This makes it easier for me to call everything
  • removed subscription parameter, since it is no longer needed in the call for the new API
  • added a billing setup commandlet which tells you if the account is connected to a subscription and if yes also giving you the subscription id
  • Added a parameter to be able to call rest endpoints without the account name in front. A few endpoints do not need this. In this case, I can use the _callApi function without the -URL parameter

PR Checklist

@SebastianSchuetze SebastianSchuetze marked this pull request as ready for review April 4, 2021 19:07
@SebastianSchuetze SebastianSchuetze changed the title Topic/billing optimized Billing Cmdlets Optimized Apr 4, 2021
@DarqueWarrior
Copy link
Collaborator

Hey, @SebastianSchuetze please review my changes and let me know if you have any concerns.

@SebastianSchuetze
Copy link
Collaborator Author

Looks good @DarqueWarrior. Can be merged!

@DarqueWarrior DarqueWarrior merged commit e75ccfe into MethodsAndPractices:trunk Apr 20, 2021
@SebastianSchuetze SebastianSchuetze deleted the topic/BillingOptimized branch June 26, 2021 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants