-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Billing Cmdlets Optimized #389
Merged
DarqueWarrior
merged 38 commits into
MethodsAndPractices:trunk
from
RazorSPoint:topic/BillingOptimized
Apr 20, 2021
Merged
Billing Cmdlets Optimized #389
DarqueWarrior
merged 38 commits into
MethodsAndPractices:trunk
from
RazorSPoint:topic/BillingOptimized
Apr 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corrected minor bugs
Changed some minor docs mistakes, style and typos
…into topic/Billing
- fixed bugs - removed Switch for bearer token in _callAPI again
It now uses the parts to build the path.
- simplified pipeline billing - added a parameter to be able to call urls without account - added unit tests and sample data
Hey, @SebastianSchuetze please review my changes and let me know if you have any concerns. |
Looks good @DarqueWarrior. Can be merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
updated changed made with PR #371
what has changed:
PR Checklist