Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security cmdlet Improvements and added Add-VSTeamBuildPermission #386

Merged
merged 6 commits into from
Jun 25, 2021
Merged

Security cmdlet Improvements and added Add-VSTeamBuildPermission #386

merged 6 commits into from
Jun 25, 2021

Conversation

SebastianSchuetze
Copy link
Collaborator

@SebastianSchuetze SebastianSchuetze commented Mar 8, 2021 •
edited
Loading

PR Summary

  • added the cmdlet Add-VSTeamBuildPermission following the other cmdlet like Add-VSTeamProjectPermission
  • changed internal functions to not have deny or allow permissions to be mandatory, because this caused not to be able to only add allow or deny permissions.
  • allowed to handle user accounts from typ 'srv' which are service accounts of Azure DevOps. Now these can be permitted as well to all functions using ACLs

PR Checklist

@SebastianSchuetze
- made deny and allow mask non mandatory
fbbb94a 
- added ability to resolve service identity descriptor
- added cmdlet Add-VSTeamBuildPermission
@SebastianSchuetze
fixed added service identity descriptor return
61a8973
SebastianSchuetze
SebastianSchuetze commented Jun 24, 2021
View reviewed changes
Copy link
Collaborator Author

@SebastianSchuetze SebastianSchuetze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some changes for my own code.

@SebastianSchuetze SebastianSchuetze merged commit 9588413 into MethodsAndPractices:trunk Jun 25, 2021
@SebastianSchuetze SebastianSchuetze deleted the topic/SecurityImprovmentsAndPermissions branch June 25, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SebastianSchuetze