Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for assigner to be a group, when requesting approvals f… #38

Conversation

jeffrey-opdam
Copy link
Contributor

Added support for assigner to be a group, when requesting approvals for a group.

@DarqueWarrior
Copy link
Collaborator

DarqueWarrior commented Feb 5, 2018

When I ran against a real approval I got this.

WARNING: VS4029130: Invalid parameter combination specified. IncludeMyGroupApprovals parameter is supported only with
parameters (releaseIdsFilter, assignedToFilter and statusFilter = Pending). Make sure that you either specify
includeMyGroupApprovals as false or specify it along with all the three mentioned parameters.

Because of this maybe this is better as a switch in a different Parameter set.

@jeffrey-opdam
Copy link
Contributor Author

  • The includeMyGroupApprovals is now only used when asignedToFilter is filled in.
  • Added an unit test for that.

@DarqueWarrior DarqueWarrior merged commit a875df9 into MethodsAndPractices:master Mar 15, 2018
@jeffrey-opdam
Copy link
Contributor Author

jeffrey-opdam commented Mar 15, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants