Addressing Issue #373 #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $dp = New-Object System.Management.Automation.RuntimeDefinedParameterDictionary | ||
|
|
||
| # Only add these options on Windows Machines | ||
| if (_isOnWindows) { |
There was a problem hiding this comment.
aren't you creating duplicate code here. the clear function has the same. Is it possible to group the dp creation?
There was a problem hiding this comment.
Good point. It is actually in four places now. Let me see about refactoring this.
There was a problem hiding this comment.
I think the code is much better now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Azure DevOps only returns 100 projects unless you override the top value. This PR allows you to set a default value of projects to return. This will allow tab completion and validation to work on all projects.
PR Checklist