Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions to get/edit code policies #37

Merged
merged 4 commits into from
Feb 25, 2018

Conversation

davidroberts63
Copy link
Contributor

Adds functions for getting and editing code policies such as 'Minimum number of reviewers'.

@davidroberts63
Copy link
Contributor Author

And of course I realize I didn't update the readme. I'll get that in the next day.

@DarqueWarrior
Copy link
Collaborator

Funny I am updating the Readme now myself. Broke my own rules.

@davidroberts63
Copy link
Contributor Author

Also note, I did put int he docs but I was unable to successfully run the gen-help.ps1. Looks like there are a number of dependencies to get that to work, node, some npm modules etc. I'm not familiar with some of the other tools (node and npm yes but the specific modules no). I'd be willing to work on adding some documentation of getting started with the gen-help script in a separate PR if you want. I'd just need a bit more info on what you do on your side to get gen-help to run correctly.

@DarqueWarrior
Copy link
Collaborator

I just updated the help for you and some other files.

@davidroberts63
Copy link
Contributor Author

Wonderful. Thanks! Do you happen to know of any good articles on generating those formats and ps type files? It looks like they are generated by something (from the comment header) but everything I read is making them by hand. So I just copied an existing one.

@DarqueWarrior
Copy link
Collaborator

I started from one provided by PowerShell. Everything I found said to copy one from PowerShell and modify. So that is what I do as well.

Sorry for the delay. I had some meetings but I have started reviewing again. Looks really good. Thanks for the PR.

@davidroberts63
Copy link
Contributor Author

No problem. Thanks for making this and for taking the time from the LoECDA.

P.S.
Tell Damian I said hello.

@davidroberts63
Copy link
Contributor Author

Is there anything else I can do to help on this PR? I know your busy so just checking in.

@DarqueWarrior
Copy link
Collaborator

Can you explain to me how the second catch will ever get a WebException? I left a comment on the code.

@davidroberts63
Copy link
Contributor Author

Those operations (Add,Update,Delete) can result in the server returning an error (400, 404, etc). Truth be told I simply copied from similar existing operations for the git repositories functions so I could try to be somewhat consistent. I could modify it to be similar to another area if there is a preference.

Didn't see a comment anywhere (in this PR or the code itself) so I hope I addressed your thoughts. Thank you for taking the time on reviewing this.

@DarqueWarrior
Copy link
Collaborator

Thanks for pointing that out. I will approve the PR and go find the other code like this a refactor it all.

@DarqueWarrior DarqueWarrior merged commit bd4ec06 into MethodsAndPractices:master Feb 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants