-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Update-VSTeamPullRequest and Add-VSTeamPullRequest #241
Add Update-VSTeamPullRequest and Add-VSTeamPullRequest #241
Conversation
thx, gonna review this soon |
I think CI builds fail not because of the changes here, but because of flawed tests. |
Fix unit tests Catch more instances to replace Add initial draft of Update-VSTeamPullRequest Add Documentation, Unit Tests, Refinements Remove mixed-up branch changes Remove mixed-up branch changes
… into update-pull-request
OK I have a few questions on this one. In Update-VSTeamPullRequest: Also the ProjectName parameter is never used and seems like it can be removed from Update-VSTeamPullRequest. I also don't think we need a Draft ParameterSet. Just remove that ParameterSet and remove all set names from Draft and Force. |
I will make the changes I think need to be made and commit them so we can review. |
Hey @MichelZ and @SebastianSchuetze can you look at my changes and make sure I have not missed anything. |
@DarqueWarrior @SebastianSchuetze The reason that both are there: It's more explicit. e.g. if you update a Also, if you want to e.g. update a draft pull request with anything, you have to think about including |
PR Summary
Add Update-VSTeamPullRequest
Add Add-VSTeamPullRequest
Fixes #120
Fixes #131
PR Checklist