Fix for #148 #232
Merged
Fix for #148 #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug in `Get-VSTeamBuildArtifact` where an error is returned because the API returns an extra record along with the list of artifacts that is called 'build.sourcelabel' and contains a URL but no "properties" object. This PR filters out this result by excluding any build artifact records returned by the API that don't contain a "properties" object. Alternatively if we think its desirable to include this artifact in the result, we could just wrap an `if` statement around the line of code that attempts to add a typename to the `properties` property, so that it doesn't attempt to do this on the one artifact where it doesn't exist.
|
Hey @markwragg . I am not the maintainer, but maybe it could be good to add a unit test to exactly for the problem you try to fix? Would that be possible? |
DarqueWarrior
added
the
Investigating
|
@markwragg would you able to add a unit test for this? Do you need help? I am also now a maintainer of this repo. So I could help you much better with problems regarding your PR. |
|
I've added a test for this in my PR #257 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in
Get-VSTeamBuildArtifactwhere an error is returned because the API returns an extra record along with the list of artifacts that is called 'build.sourcelabel' and contains a URL but no "properties" object.This PR stops the error by excluding any build artifact records returned by the API that don't contain a "properties" object from getting the build artifact specific type names applied. The result is still returned to the user however.
Alternatively if we think it would be better to exclude this result entirely, then it could instead be filtered out in the
Get-VSTeamBuildArtifactfunction.PR Summary
PR Checklist